diff options
| author | David Woodhouse <David.Woodhouse@intel.com> | 2010-07-14 18:54:01 +0800 |
|---|---|---|
| committer | David Woodhouse <David.Woodhouse@intel.com> | 2010-07-15 23:48:45 +0800 |
| commit | 8ae4bf802aac4218ebfbe10cae09693ba64c05f3 (patch) | |
| tree | 4e50ee1855cdf96f5b936040dcafded1b312959f /mail/e-mail-reader.c | |
| parent | 1e6adfccc83fdbf7862fabd883ca1ba8d9a848c2 (diff) | |
| download | gsoc2013-evolution-8ae4bf802aac4218ebfbe10cae09693ba64c05f3.tar.gz gsoc2013-evolution-8ae4bf802aac4218ebfbe10cae09693ba64c05f3.tar.zst gsoc2013-evolution-8ae4bf802aac4218ebfbe10cae09693ba64c05f3.zip | |
Fix two memory leaks when replying
1: em_utils_reply_to_message() can be passed a newly-created message (from
a current selection. It needs to unref it. Which means that when we pass it
a message which *isn't* newly-created, we have to obtain a ref of our own.
It was that or add a boolean parameter to tell it whether to unref or not.
2: emf_finalize() wasn't unreferencing emf->message -- so when we clone
the EMFormat in em_utils_message_to_html() and immediately unreference the
clone, a refcount on the message got leaked. Fix emf_finalize() to unref
emf->message as presumably it should.
Diffstat (limited to 'mail/e-mail-reader.c')
| -rw-r--r-- | mail/e-mail-reader.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/mail/e-mail-reader.c b/mail/e-mail-reader.c index d9f49bfee0..74f0e7c544 100644 --- a/mail/e-mail-reader.c +++ b/mail/e-mail-reader.c @@ -832,6 +832,9 @@ action_mail_reply_all_check(CamelFolder *folder, const gchar *uid, CamelMimeMess if (!message) return; + /* get_message_free() will unref the message, so we need to take an + extra ref for e_mail_reader_reply_to_message() to own. */ + g_object_ref(message); to = camel_mime_message_get_recipients (message, CAMEL_RECIPIENT_TYPE_TO); cc = camel_mime_message_get_recipients (message, CAMEL_RECIPIENT_TYPE_CC); |