diff options
author | Leonid Logvinov <logvinov.leon@gmail.com> | 2018-08-03 19:38:40 +0800 |
---|---|---|
committer | Leonid Logvinov <logvinov.leon@gmail.com> | 2018-08-03 19:38:40 +0800 |
commit | 749ec0cefe095805f76dca2f81025ebfbd98de2a (patch) | |
tree | 696ae1dd65fa3ad4ae578a6e18c538fbf7c01918 | |
parent | bd488020df0911ab581ad401097a3a97a8048c60 (diff) | |
download | dexon-0x-contracts-749ec0cefe095805f76dca2f81025ebfbd98de2a.tar.gz dexon-0x-contracts-749ec0cefe095805f76dca2f81025ebfbd98de2a.tar.zst dexon-0x-contracts-749ec0cefe095805f76dca2f81025ebfbd98de2a.zip |
Add a TODO for failed transactions
-rw-r--r-- | packages/sol-cov/src/trace_collection_subprovider.ts | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/packages/sol-cov/src/trace_collection_subprovider.ts b/packages/sol-cov/src/trace_collection_subprovider.ts index b530b59db..0aa592bd5 100644 --- a/packages/sol-cov/src/trace_collection_subprovider.ts +++ b/packages/sol-cov/src/trace_collection_subprovider.ts @@ -176,6 +176,7 @@ export abstract class TraceCollectionSubprovider extends Subprovider { const txHash = await this._web3Wrapper.sendTransactionAsync(fakeTxData); await this._web3Wrapper.awaitTransactionMinedAsync(txHash, 0); } catch (err) { + // TODO(logvinov) Check that transaction failed and not some other exception // Even if this transaction failed - we've already recorded it's trace. _.noop(); } |