diff options
author | Jacob Evans <jacob@dekz.net> | 2018-03-06 21:57:54 +0800 |
---|---|---|
committer | Jacob Evans <jacob@dekz.net> | 2018-03-06 21:57:54 +0800 |
commit | f3026e33fd439bbd550e1814b5f067c36290638b (patch) | |
tree | 227e7486fa14f00a6b55e699f62b42caf6c35f77 | |
parent | 7bfc499ec8e50778dd33183646dd19ef66496052 (diff) | |
download | dexon-0x-contracts-f3026e33fd439bbd550e1814b5f067c36290638b.tar.gz dexon-0x-contracts-f3026e33fd439bbd550e1814b5f067c36290638b.tar.zst dexon-0x-contracts-f3026e33fd439bbd550e1814b5f067c36290638b.zip |
Force shouldGetChainCode to true in types
-rw-r--r-- | packages/subproviders/src/types.ts | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/packages/subproviders/src/types.ts b/packages/subproviders/src/types.ts index 11a178f69..f49ac6107 100644 --- a/packages/subproviders/src/types.ts +++ b/packages/subproviders/src/types.ts @@ -10,10 +10,12 @@ export interface LedgerCommunicationClient { * NodeJs and Browser communication are supported. */ export interface LedgerEthereumClient { + // shouldGetChainCode is defined as `true` instead of `boolean` because other types rely on the assumption + // that we get back the chain code and we don't have dependent types to express it properly getAddress: ( derivationPath: string, - askForDeviceConfirmation?: boolean, - shouldGetChainCode?: boolean, + askForDeviceConfirmation: boolean, + shouldGetChainCode: true, ) => Promise<LedgerGetAddressResult>; signTransaction: (derivationPath: string, rawTxHex: string) => Promise<ECSignatureString>; signPersonalMessage: (derivationPath: string, messageHex: string) => Promise<ECSignature>; |