diff options
author | fragosti <francesco.agosti93@gmail.com> | 2018-08-15 08:16:03 +0800 |
---|---|---|
committer | fragosti <francesco.agosti93@gmail.com> | 2018-08-15 08:16:03 +0800 |
commit | 80e5127a469a0f38cddc18a45a4a7e019191760c (patch) | |
tree | 6f204b4d0f91221bb35f3a9727ad29c122024981 /packages/connect | |
parent | 5c40c466f6e9f690afa86f23dd5ba240691dceb8 (diff) | |
download | dexon-0x-contracts-80e5127a469a0f38cddc18a45a4a7e019191760c.tar.gz dexon-0x-contracts-80e5127a469a0f38cddc18a45a4a7e019191760c.tar.zst dexon-0x-contracts-80e5127a469a0f38cddc18a45a4a7e019191760c.zip |
Update types and add missing param to SRA spec
Diffstat (limited to 'packages/connect')
-rw-r--r-- | packages/connect/package.json | 2 | ||||
-rw-r--r-- | packages/connect/src/types.ts | 36 | ||||
-rw-r--r-- | packages/connect/src/utils/assert.ts | 3 |
3 files changed, 22 insertions, 19 deletions
diff --git a/packages/connect/package.json b/packages/connect/package.json index 39376a9a6..336cb85fc 100644 --- a/packages/connect/package.json +++ b/packages/connect/package.json @@ -53,7 +53,7 @@ "dependencies": { "@0xproject/assert": "^0.2.14", "@0xproject/json-schemas": "^1.0.1-rc.4", - "@0xproject/types": "^0.8.2", + "@0xproject/types": "^1.0.1-rc.4", "@0xproject/typescript-typings": "^1.0.4", "@0xproject/utils": "^1.0.5", "lodash": "^4.17.5", diff --git a/packages/connect/src/types.ts b/packages/connect/src/types.ts index fb51dca98..dab01c935 100644 --- a/packages/connect/src/types.ts +++ b/packages/connect/src/types.ts @@ -94,14 +94,18 @@ export interface Asset { } export interface OrdersRequestOpts { + makerAssetProxyId?: string; + takerAssetProxyId?: string; + makerAssetAddress?: string; + takerAssetAddress?: string; exchangeAddress?: string; - tokenAddress?: string; - makerTokenAddress?: string; - takerTokenAddress?: string; - maker?: string; - taker?: string; - trader?: string; - feeRecipient?: string; + senderAddress?: string; + makerAssetData?: string; + takerAssetData?: string; + makerAddress?: string; + takerAddress?: string; + traderAddress?: string; + feeRecipientAddress?: string; } export interface OrderbookRequest { @@ -122,21 +126,21 @@ export interface PaginatedCollection<T> { } export interface OrderConfigRequest { + makerAddress: string; + takerAddress: string; + makerAssetAmount: string; + takerAssetAmount: string; + makerAssetData: string; + takerAssetData: string; exchangeAddress: string; - maker: string; - taker: string; - makerTokenAddress: string; - takerTokenAddress: string; - makerAssetAmount: BigNumber; - takerAssetAmount: BigNumber; - expirationTimeSeconds: BigNumber; - salt: BigNumber; + expirationTimeSeconds: string; } export interface OrderConfigResponse { - feeRecipient: string; makerFee: BigNumber; takerFee: BigNumber; + feeRecipientAddress: string; + senderAddress: string; } export interface PagedRequestOpts { diff --git a/packages/connect/src/utils/assert.ts b/packages/connect/src/utils/assert.ts index a0fd12fbd..353b7f29f 100644 --- a/packages/connect/src/utils/assert.ts +++ b/packages/connect/src/utils/assert.ts @@ -14,11 +14,10 @@ export const assert = { sharedAssert.doesConformToSchema( variableName, subscriptionOpts, - schemas.relayerApiOrderbookChannelSubscribePayload, + schemas.relayerApiOrdersChannelSubscribePayload, ); }, isOrderbookChannelHandler(variableName: string, handler: any): void { - sharedAssert.isFunction(`${variableName}.onSnapshot`, _.get(handler, 'onSnapshot')); sharedAssert.isFunction(`${variableName}.onUpdate`, _.get(handler, 'onUpdate')); sharedAssert.isFunction(`${variableName}.onError`, _.get(handler, 'onError')); sharedAssert.isFunction(`${variableName}.onClose`, _.get(handler, 'onClose')); |