diff options
author | Leonid Logvinov <logvinov.leon@gmail.com> | 2018-06-29 20:30:10 +0800 |
---|---|---|
committer | Leonid Logvinov <logvinov.leon@gmail.com> | 2018-06-29 22:52:54 +0800 |
commit | bcc588efe726751c100f020a219b79d8f2a31f03 (patch) | |
tree | c34f1da11e6833efcde81734bc5f43b17e267d57 /packages/contract-wrappers/src/contract_wrappers | |
parent | f7b3fc58bc24decc37f7c64b15573a5ec90e1ceb (diff) | |
download | dexon-0x-contracts-bcc588efe726751c100f020a219b79d8f2a31f03.tar.gz dexon-0x-contracts-bcc588efe726751c100f020a219b79d8f2a31f03.tar.zst dexon-0x-contracts-bcc588efe726751c100f020a219b79d8f2a31f03.zip |
Add HACK comments
Diffstat (limited to 'packages/contract-wrappers/src/contract_wrappers')
4 files changed, 8 insertions, 0 deletions
diff --git a/packages/contract-wrappers/src/contract_wrappers/erc20_proxy_wrapper.ts b/packages/contract-wrappers/src/contract_wrappers/erc20_proxy_wrapper.ts index d1ec5b08a..839248754 100644 --- a/packages/contract-wrappers/src/contract_wrappers/erc20_proxy_wrapper.ts +++ b/packages/contract-wrappers/src/contract_wrappers/erc20_proxy_wrapper.ts @@ -49,6 +49,8 @@ export class ERC20ProxyWrapper extends ContractWrapper { const contractAddress = this._getContractAddress(artifacts.ERC20Proxy, this._contractAddressIfExists); return contractAddress; } + // HACK: We don't want this method to be visible to the other units within that package but not to the end user. + // TS doesn't give that possibility and therefore we make it private and access it over an any cast. Because of that tslint sees it as unused. // tslint:disable-next-line:no-unused-variable private _invalidateContractInstance(): void { delete this._erc20ProxyContractIfExists; diff --git a/packages/contract-wrappers/src/contract_wrappers/erc20_token_wrapper.ts b/packages/contract-wrappers/src/contract_wrappers/erc20_token_wrapper.ts index 014e96fa3..49adba1f9 100644 --- a/packages/contract-wrappers/src/contract_wrappers/erc20_token_wrapper.ts +++ b/packages/contract-wrappers/src/contract_wrappers/erc20_token_wrapper.ts @@ -406,6 +406,8 @@ export class ERC20TokenWrapper extends ContractWrapper { ); return logs; } + // HACK: We don't want this method to be visible to the other units within that package but not to the end user. + // TS doesn't give that possibility and therefore we make it private and access it over an any cast. Because of that tslint sees it as unused. // tslint:disable-next-line:no-unused-variable private _invalidateContractInstances(): void { this.unsubscribeAll(); diff --git a/packages/contract-wrappers/src/contract_wrappers/erc721_proxy_wrapper.ts b/packages/contract-wrappers/src/contract_wrappers/erc721_proxy_wrapper.ts index fbe32a7c5..fba995395 100644 --- a/packages/contract-wrappers/src/contract_wrappers/erc721_proxy_wrapper.ts +++ b/packages/contract-wrappers/src/contract_wrappers/erc721_proxy_wrapper.ts @@ -49,6 +49,8 @@ export class ERC721ProxyWrapper extends ContractWrapper { const contractAddress = this._getContractAddress(artifacts.ERC721Proxy, this._contractAddressIfExists); return contractAddress; } + // HACK: We don't want this method to be visible to the other units within that package but not to the end user. + // TS doesn't give that possibility and therefore we make it private and access it over an any cast. Because of that tslint sees it as unused. // tslint:disable-next-line:no-unused-variable private _invalidateContractInstance(): void { delete this._erc721ProxyContractIfExists; diff --git a/packages/contract-wrappers/src/contract_wrappers/erc721_token_wrapper.ts b/packages/contract-wrappers/src/contract_wrappers/erc721_token_wrapper.ts index f32827191..86c3e2d99 100644 --- a/packages/contract-wrappers/src/contract_wrappers/erc721_token_wrapper.ts +++ b/packages/contract-wrappers/src/contract_wrappers/erc721_token_wrapper.ts @@ -442,6 +442,8 @@ export class ERC721TokenWrapper extends ContractWrapper { ); return logs; } + // HACK: We don't want this method to be visible to the other units within that package but not to the end user. + // TS doesn't give that possibility and therefore we make it private and access it over an any cast. Because of that tslint sees it as unused. // tslint:disable-next-line:no-unused-variable private _invalidateContractInstances(): void { this.unsubscribeAll(); |