diff options
| author | Jacob Evans <jacob@dekz.net> | 2018-09-26 13:41:49 +0800 |
|---|---|---|
| committer | Jacob Evans <jacob@dekz.net> | 2018-09-28 07:59:58 +0800 |
| commit | 21f60721863c974e0565009100891db53b7fb42c (patch) | |
| tree | 26a7a26023e29b669c79ea4989af81ba1c84d6ec /packages/sol-compiler/src | |
| parent | bf3795d2acd377c6896bf3e825d43b8697a12f67 (diff) | |
| download | dexon-0x-contracts-21f60721863c974e0565009100891db53b7fb42c.tar.gz dexon-0x-contracts-21f60721863c974e0565009100891db53b7fb42c.tar.zst dexon-0x-contracts-21f60721863c974e0565009100891db53b7fb42c.zip | |
Handle revert with reason when decoding call result
We use in-process ganache which throws on an RPC error. This means all of our tests get a nice revert error thrown when testing against ganache. This is not possible with RPC providers and a revert with reason result is returned. Our callAsync doesn't handle this and attempts to decode the revert with reason error log as a successful log, which results in an error while decoding.
This only works with our fork of ethers https://github.com/ethers-io/ethers.js/pull/188 and will need to be re-worked when updating to Ethers.js 4
Diffstat (limited to 'packages/sol-compiler/src')
0 files changed, 0 insertions, 0 deletions