diff options
| author | Fabio Berger <me@fabioberger.com> | 2018-05-23 00:04:50 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-05-23 00:04:50 +0800 |
| commit | cc840a6911850856c3254f7ac73cd70c527e1a5c (patch) | |
| tree | c7435ac7ce09541a67f0106a85f391dc48921e10 /packages/sra-report/test | |
| parent | a26cc7c14d4e59102d5f84d534f75c42b8683cad (diff) | |
| parent | c4a2f700172e8be367225d90a1c51cef8cf0d7dd (diff) | |
| download | dexon-0x-contracts-cc840a6911850856c3254f7ac73cd70c527e1a5c.tar.gz dexon-0x-contracts-cc840a6911850856c3254f7ac73cd70c527e1a5c.tar.zst dexon-0x-contracts-cc840a6911850856c3254f7ac73cd70c527e1a5c.zip | |
Merge pull request #594 from 0xProject/improvement/addCustomTslintRules
Add more tslint rules
Diffstat (limited to 'packages/sra-report/test')
| -rw-r--r-- | packages/sra-report/test/test_runner.ts | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/packages/sra-report/test/test_runner.ts b/packages/sra-report/test/test_runner.ts index 5ea3cdc4d..fe238e98a 100644 --- a/packages/sra-report/test/test_runner.ts +++ b/packages/sra-report/test/test_runner.ts @@ -24,6 +24,7 @@ const expect = chai.expect; const CONTENT_TYPE_ASSERTION_NAME = 'Has Content-Type header with value application/json'; const SCHEMA_ASSERTION_NAME = 'Schema is valid'; +const SUCCESS_STATUS = 200; const baseNewmanRunOptions = { collection: sraReportCollectionJSON, environment: postmanEnvironmentJSON, @@ -46,7 +47,7 @@ export const testRunner = { }; describe(CONTENT_TYPE_ASSERTION_NAME, () => { it('fails when there are no headers', async () => { - nockInterceptor.reply(200, {}); + nockInterceptor.reply(SUCCESS_STATUS, {}); const summary = await utils.newmanRunAsync(newmanRunOptions); const error = findAssertionErrorIfExists( summary, @@ -61,7 +62,7 @@ export const testRunner = { const headers = { 'Content-Type': 'text/html', }; - nockInterceptor.reply(200, {}, headers); + nockInterceptor.reply(SUCCESS_STATUS, {}, headers); const summary = await utils.newmanRunAsync(newmanRunOptions); const error = findAssertionErrorIfExists( summary, @@ -76,7 +77,7 @@ export const testRunner = { const headers = { 'Content-Type': 'charset=utf-8; application/json', }; - nockInterceptor.reply(200, {}, headers); + nockInterceptor.reply(SUCCESS_STATUS, {}, headers); const summary = await utils.newmanRunAsync(newmanRunOptions); const error = findAssertionErrorIfExists( summary, @@ -100,7 +101,7 @@ export const testRunner = { }; describe(SCHEMA_ASSERTION_NAME, () => { it('fails when schema is invalid', async () => { - nockInterceptor.reply(200, malformedJson); + nockInterceptor.reply(SUCCESS_STATUS, malformedJson); const summary = await utils.newmanRunAsync(newmanRunOptions); const error = findAssertionErrorIfExists(summary, postmanCollectionRequestName, SCHEMA_ASSERTION_NAME); const errorMessage = _.get(error, 'message'); @@ -108,7 +109,7 @@ export const testRunner = { expect(errorMessage).to.equal('expected false to be true'); }); it('passes when schema is valid', async () => { - nockInterceptor.reply(200, correctJson); + nockInterceptor.reply(SUCCESS_STATUS, correctJson); const summary = await utils.newmanRunAsync(newmanRunOptions); const error = findAssertionErrorIfExists(summary, postmanCollectionRequestName, SCHEMA_ASSERTION_NAME); const errorMessage = _.get(error, 'message'); |