Merge pull request #662 from 0xProject/feature/improve-linting

Tried enabling no-unused-variable...

3 files changed, 5 insertions, 2 deletions

diff --git a/packages/tslint-config/rules/booleanNamingRule.ts b/packages/tslint-config/rules/booleanNamingRule.ts
index a8e1dc390..6590f689b 100644
--- a/packages/tslint-config/rules/booleanNamingRule.ts
+++ b/packages/tslint-config/rules/booleanNamingRule.ts
@@ -3,7 +3,7 @@ import * as Lint from 'tslint';
 import * as ts from 'typescript';
 
 const VALID_BOOLEAN_PREFIXES = ['is', 'does', 'should', 'was', 'has', 'can', 'did', 'would', 'are'];
-
+// tslint:disable:no-unnecessary-type-assertion
 export class Rule extends Lint.Rules.TypedRule {
     public static FAILURE_STRING = `Boolean variable names should begin with: ${VALID_BOOLEAN_PREFIXES.join(', ')}`;
 
@@ -66,3 +66,4 @@ function handleBooleanNaming(
         }
     }
 }
+// tslint:enable:no-unnecessary-type-assertion
diff --git a/packages/tslint-config/rules/customNoMagicNumbersRule.ts b/packages/tslint-config/rules/customNoMagicNumbersRule.ts
index e358221eb..0a565b2e6 100644
--- a/packages/tslint-config/rules/customNoMagicNumbersRule.ts
+++ b/packages/tslint-config/rules/customNoMagicNumbersRule.ts
@@ -2,6 +2,7 @@ import * as Lint from 'tslint';
 import { isPrefixUnaryExpression } from 'tsutils';
 import * as ts from 'typescript';
 
+// tslint:disable:no-unnecessary-type-assertion
 /**
  * A modified version of the no-magic-numbers rule that allows for magic numbers
  * when instantiating a BigNumber instance.
@@ -74,3 +75,4 @@ class CustomNoMagicNumbersWalker extends Lint.AbstractWalker<Set<string>> {
     }
     // tslint:enable:no-non-null-assertion
 }
+// tslint:enable:no-unnecessary-type-assertion
diff --git a/packages/tslint-config/tslint.json b/packages/tslint-config/tslint.json
index ec414fb71..680883f47 100644
--- a/packages/tslint-config/tslint.json
+++ b/packages/tslint-config/tslint.json
@@ -29,7 +29,6 @@
         "interface-name": false,
         "interface-over-type-literal": true,
         "linebreak-style": [true, "LF"],
-        "max-classes-per-file": false,
         "max-classes-per-file": [true, 1],
         "max-line-length": false,
         "max-file-line-count": [true, 500],
@@ -46,6 +45,7 @@
         "no-parameter-reassignment": true,
         "no-redundant-jsdoc": true,
         "no-return-await": true,
+        "no-unused-variable": true,
         "no-string-throw": true,
         "no-submodule-imports": false,
         "no-unnecessary-type-assertion": true,