diff options
author | Jacob Evans <dekz@dekz.net> | 2018-06-25 13:47:07 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-06-25 13:47:07 +0800 |
commit | 0cd37cbf7e9d2c73fbe617b4f1505875b48dae9b (patch) | |
tree | c72718e642e68524d2aa473121b24e68b1c141f9 | |
parent | d621e4201d0c9729bb5a999c77e32141bb929279 (diff) | |
parent | b2a4b7eb888131608d2526d806bc0461c31e8aef (diff) | |
download | dexon-sol-tools-0cd37cbf7e9d2c73fbe617b4f1505875b48dae9b.tar.gz dexon-sol-tools-0cd37cbf7e9d2c73fbe617b4f1505875b48dae9b.tar.zst dexon-sol-tools-0cd37cbf7e9d2c73fbe617b4f1505875b48dae9b.zip |
Merge pull request #758 from 0xProject/fix/order-utils/known-order-hash
Fix known order hash value test in order-utils
-rw-r--r-- | packages/order-utils/test/order_hash_test.ts | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/packages/order-utils/test/order_hash_test.ts b/packages/order-utils/test/order_hash_test.ts index 28bfcbafc..0a6be83d0 100644 --- a/packages/order-utils/test/order_hash_test.ts +++ b/packages/order-utils/test/order_hash_test.ts @@ -12,8 +12,8 @@ const expect = chai.expect; describe('Order hashing', () => { describe('#getOrderHashHex', () => { - const expectedOrderHash = '0x367ad7730eb8b5feab8a9c9f47c6fcba77a2d4df125ee6a59cc26ac955710f7e'; - const fakeExchangeContractAddress = '0xb69e673309512a9d726f87304c6984054f87a93b'; + const expectedOrderHash = '0x434c6b41e2fb6dfcfe1b45c4492fb03700798e9c1afc6f801ba6203f948c1fa7'; + const fakeExchangeContractAddress = '0x1dc4c1cefef38a777b15aa20260a54e584b16c48'; const order: Order = { makerAddress: constants.NULL_ADDRESS, takerAddress: constants.NULL_ADDRESS, @@ -29,15 +29,11 @@ describe('Order hashing', () => { takerAssetAmount: new BigNumber(0), expirationTimeSeconds: new BigNumber(0), }; - // HACK: Temporarily disable these tests until @dekz has time to fix. - // This allows us to get all tests running on CI immediately - it.skip('calculates the order hash', async () => { + it('calculates the order hash', async () => { const orderHash = orderHashUtils.getOrderHashHex(order); expect(orderHash).to.be.equal(expectedOrderHash); }); - // HACK: Temporarily disable these tests until @dekz has time to fix. - // This allows us to get all tests running on CI immediately - it.skip('throws a readable error message if taker format is invalid', async () => { + it('throws a readable error message if taker format is invalid', async () => { const orderWithInvalidtakerFormat = { ...order, takerAddress: (null as any) as string, |