diff options
| author | fragosti <francesco.agosti93@gmail.com> | 2018-11-29 04:58:11 +0800 |
|---|---|---|
| committer | fragosti <francesco.agosti93@gmail.com> | 2018-11-29 05:09:05 +0800 |
| commit | 1375d694ac2026ff8fe553f2b7bc9daa4d5f6d7d (patch) | |
| tree | 3d92f8fb29af60311e08a0a23145eab53b5ed496 | |
| parent | 53f8e1b3b426424bf4459605b48e706eb7fb6d90 (diff) | |
| download | dexon-sol-tools-1375d694ac2026ff8fe553f2b7bc9daa4d5f6d7d.tar.gz dexon-sol-tools-1375d694ac2026ff8fe553f2b7bc9daa4d5f6d7d.tar.zst dexon-sol-tools-1375d694ac2026ff8fe553f2b7bc9daa4d5f6d7d.zip | |
fix: instant error no longer makes instant move
| -rw-r--r-- | packages/instant/src/components/ui/container.tsx | 2 | ||||
| -rw-r--r-- | packages/instant/src/containers/latest_error.tsx | 8 |
2 files changed, 9 insertions, 1 deletions
diff --git a/packages/instant/src/components/ui/container.tsx b/packages/instant/src/components/ui/container.tsx index 4dafe1386..2143b0503 100644 --- a/packages/instant/src/components/ui/container.tsx +++ b/packages/instant/src/components/ui/container.tsx @@ -28,6 +28,7 @@ export interface ContainerProps { className?: string; backgroundColor?: ColorOption; hasBoxShadow?: boolean; + isHidden?: boolean; zIndex?: number; whiteSpace?: string; opacity?: number; @@ -70,6 +71,7 @@ export const Container = ${props => props.width && stylesForMedia<string>('width', props.width)} ${props => props.height && stylesForMedia<string>('height', props.height)} ${props => props.borderRadius && stylesForMedia<string>('border-radius', props.borderRadius)} + ${props => (props.isHidden ? 'visibility: hidden;' : '')} background-color: ${props => (props.backgroundColor ? props.theme[props.backgroundColor] : 'none')}; border-color: ${props => (props.borderColor ? props.theme[props.borderColor] : 'none')}; &:hover { diff --git a/packages/instant/src/containers/latest_error.tsx b/packages/instant/src/containers/latest_error.tsx index b7cfdb504..0d4349124 100644 --- a/packages/instant/src/containers/latest_error.tsx +++ b/packages/instant/src/containers/latest_error.tsx @@ -4,6 +4,7 @@ import { connect } from 'react-redux'; import { Dispatch } from 'redux'; import { SlidingError } from '../components/sliding_error'; +import { Container } from '../components/ui/container'; import { Overlay } from '../components/ui/overlay'; import { Action } from '../redux/actions'; import { State } from '../redux/reducer'; @@ -23,7 +24,12 @@ export interface LatestErrorComponentProps { export const LatestErrorComponent: React.StatelessComponent<LatestErrorComponentProps> = props => { if (!props.latestErrorMessage) { - return <div />; + // Render a hidden SlidingError such that instant does not move when a real error is rendered. + return ( + <Container isHidden={true}> + <SlidingError animationState="slidIn" icon="😢" message="" /> + </Container> + ); } return ( <React.Fragment> |