diff options
author | Steve Klebanoff <steve@0xproject.com> | 2018-11-27 07:10:50 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-11-27 07:10:50 +0800 |
commit | 6e3d70af566b9d1fcfce83a055793a08f19ee160 (patch) | |
tree | 4a5ddb3f29b5630098688b1c68dfaa88282f6038 | |
parent | 825911ed89e63f065c1a843ad83fb28ed72bb8ee (diff) | |
parent | 6eec84d21b4337229f379513248e1b98e0ae3108 (diff) | |
download | dexon-sol-tools-6e3d70af566b9d1fcfce83a055793a08f19ee160.tar.gz dexon-sol-tools-6e3d70af566b9d1fcfce83a055793a08f19ee160.tar.zst dexon-sol-tools-6e3d70af566b9d1fcfce83a055793a08f19ee160.zip |
Merge pull request #1299 from 0xProject/feature/instant/open-close-events
[instant] Add more event properties
-rw-r--r-- | packages/instant/src/components/zero_ex_instant_provider.tsx | 17 | ||||
-rw-r--r-- | packages/instant/src/util/analytics.ts | 27 |
2 files changed, 36 insertions, 8 deletions
diff --git a/packages/instant/src/components/zero_ex_instant_provider.tsx b/packages/instant/src/components/zero_ex_instant_provider.tsx index 9814aabf8..fe34c4466 100644 --- a/packages/instant/src/components/zero_ex_instant_provider.tsx +++ b/packages/instant/src/components/zero_ex_instant_provider.tsx @@ -125,14 +125,15 @@ export class ZeroExInstantProvider extends React.Component<ZeroExInstantProvider // Analytics disableAnalytics(this.props.shouldDisableAnalyticsTracking || false); - analytics.addEventProperties({ - embeddedHost: window.location.host, - embeddedUrl: window.location.href, - networkId: state.network, - providerName: state.providerState.name, - gitSha: process.env.GIT_SHA, - npmVersion: process.env.NPM_PACKAGE_VERSION, - }); + analytics.addEventProperties( + analytics.generateEventProperties( + state.network, + this.props.orderSource, + state.providerState, + window, + this.props.affiliateInfo, + ), + ); analytics.trackInstantOpened(); } public componentWillUnmount(): void { diff --git a/packages/instant/src/util/analytics.ts b/packages/instant/src/util/analytics.ts index e389e1530..cec99dd1b 100644 --- a/packages/instant/src/util/analytics.ts +++ b/packages/instant/src/util/analytics.ts @@ -1,3 +1,5 @@ +import { AffiliateInfo, Network, OrderSource, ProviderState } from '../types'; + import { EventProperties, heapUtil } from './heap'; let isDisabled = false; @@ -47,6 +49,9 @@ export interface AnalyticsEventOptions { providerName?: string; gitSha?: string; npmVersion?: string; + orderSource?: string; + affiliateAddress?: string; + affiliateFeePercent?: number; } export const analytics = { @@ -60,6 +65,28 @@ export const analytics = { heapUtil.evaluateHeapCall(heap => heap.addEventProperties(properties)); }); }, + generateEventProperties: ( + network: Network, + orderSource: OrderSource, + providerState: ProviderState, + window: Window, + affiliateInfo?: AffiliateInfo, + ): AnalyticsEventOptions => { + const affiliateAddress = affiliateInfo ? affiliateInfo.feeRecipient : 'none'; + const affiliateFeePercent = affiliateInfo ? parseFloat(affiliateInfo.feePercentage.toFixed(4)) : 0; + const orderSourceName = typeof orderSource === 'string' ? orderSource : 'provided'; + return { + embeddedHost: window.location.host, + embeddedUrl: window.location.href, + networkId: network, + providerName: providerState.name, + gitSha: process.env.GIT_SHA, + npmVersion: process.env.NPM_PACKAGE_VERSION, + orderSource: orderSourceName, + affiliateAddress, + affiliateFeePercent, + }; + }, trackInstantOpened: trackingEventFnWithoutPayload(EventNames.INSTANT_OPENED), trackAccountLocked: trackingEventFnWithoutPayload(EventNames.ACCOUNT_LOCKED), trackAccountReady: (address: string) => trackingEventFnWithPayload(EventNames.ACCOUNT_READY)({ address }), |