diff options
author | Amir Bandeali <abandeali1@gmail.com> | 2018-08-29 04:00:49 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-08-29 04:00:49 +0800 |
commit | 14fdb71a716cb95bc1f6933db9057d23f3c41909 (patch) | |
tree | 9690b583d128f419f292ef78f0a70be260e8babe /packages/contracts/src/2.0.0/test/ReentrantERC20Token | |
parent | 2eab0e30b753fb33729db53d141c8e22017cadec (diff) | |
download | dexon-sol-tools-14fdb71a716cb95bc1f6933db9057d23f3c41909.tar.gz dexon-sol-tools-14fdb71a716cb95bc1f6933db9057d23f3c41909.tar.zst dexon-sol-tools-14fdb71a716cb95bc1f6933db9057d23f3c41909.zip |
safeGetPartialAmount (#1035)
* Added Test "Should transfer correct amounts when left order is fully filled and values pass isRoundingErrorCeil but fail isRoundingErrorFloor"
* Added RoundingError exception to reference function for getPartialAmount
* Added RoundingError exception to reference function for getPartialAmount
* Added isRoundingErrorCeil to getPartialAmountCeil reference funtion
* Computed new values for "Should give right maker a better buy price when correct price is not integral" that does not have a rounding error
* Almost all tests for match orders are passing after adding isRoundingErrorCeil check
* WIP commit: Added rounding error checks to getPartialAmount
* WIP commit: Added rounding error checks to getPartialAmount
* Use safe versions of getPartialAmount
* Update Exchange internals tests
* Run linter
* Found new values for "Should transfer correct amounts when right order fill amount deviates from amount derived by `Exchange.fillOrder`"
* Fixed merge conflicts
* Run all tests
* Cleaned up some comments on match Orders tests
* Fix tests for geth
Diffstat (limited to 'packages/contracts/src/2.0.0/test/ReentrantERC20Token')
-rw-r--r-- | packages/contracts/src/2.0.0/test/ReentrantERC20Token/ReentrantERC20Token.sol | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/packages/contracts/src/2.0.0/test/ReentrantERC20Token/ReentrantERC20Token.sol b/packages/contracts/src/2.0.0/test/ReentrantERC20Token/ReentrantERC20Token.sol index 8bfdd2e66..4f4e28302 100644 --- a/packages/contracts/src/2.0.0/test/ReentrantERC20Token/ReentrantERC20Token.sol +++ b/packages/contracts/src/2.0.0/test/ReentrantERC20Token/ReentrantERC20Token.sol @@ -25,6 +25,7 @@ import "../../protocol/Exchange/interfaces/IExchange.sol"; import "../../protocol/Exchange/libs/LibOrder.sol"; +// solhint-disable no-unused-vars contract ReentrantERC20Token is ERC20Token { |