Merge branch 'development' into feature/instant/asset-buyer-check-liquidity

7 files changed, 93 insertions, 36 deletions

diff --git a/packages/monorepo-scripts/src/constants.ts b/packages/monorepo-scripts/src/constants.ts
index acb4b211e..c15bcabf4 100644
--- a/packages/monorepo-scripts/src/constants.ts
+++ b/packages/monorepo-scripts/src/constants.ts
@@ -5,5 +5,7 @@ export const constants = {
     stagingWebsite: 'http://staging-0xproject.s3-website-us-east-1.amazonaws.com',
     lernaExecutable: path.join('node_modules', '@0x-lerna-fork', 'lerna', 'cli.js'),
     githubPersonalAccessToken: process.env.GITHUB_PERSONAL_ACCESS_TOKEN_0X_JS,
+    discordAlertWebhookUrl: process.env.DISCORD_GITHUB_RELEASE_WEBHOOK_URL,
+    releasesUrl: 'https://github.com/0xProject/0x-monorepo/releases',
     dependenciesUpdatedMessage: 'Dependencies updated',
 };
diff --git a/packages/monorepo-scripts/src/doc_gen_configs.ts b/packages/monorepo-scripts/src/doc_gen_configs.ts
index 7a14f8664..7a4e6bb2c 100644
--- a/packages/monorepo-scripts/src/doc_gen_configs.ts
+++ b/packages/monorepo-scripts/src/doc_gen_configs.ts
@@ -9,6 +9,7 @@ export const docGenConfigs: DocGenConfigs = {
         Array: 'https://developer.mozilla.org/pt-PT/docs/Web/JavaScript/Reference/Global_Objects/Array',
         BigNumber: 'http://mikemcl.github.io/bignumber.js',
         Error: 'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error',
+        ErrorConstructor: 'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error',
         Buffer: 'https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/v9/index.d.ts#L262',
         'solc.StandardContractOutput':
             'https://solidity.readthedocs.io/en/v0.4.24/using-the-compiler.html#output-description',
@@ -37,6 +38,7 @@ export const docGenConfigs: DocGenConfigs = {
     // and getting confused. Any class name in this list will not have it's constructor rendered in our docs.
     CLASSES_WITH_HIDDEN_CONSTRUCTORS: [
         'AssetBuyer',
+        'DutchAuctionWrapper',
         'ERC20ProxyWrapper',
         'ERC20TokenWrapper',
         'ERC721ProxyWrapper',
diff --git a/packages/monorepo-scripts/src/prepublish_checks.ts b/packages/monorepo-scripts/src/prepublish_checks.ts
index 36e61714b..82eaf5cf9 100644
--- a/packages/monorepo-scripts/src/prepublish_checks.ts
+++ b/packages/monorepo-scripts/src/prepublish_checks.ts
@@ -140,6 +140,13 @@ async function checkPublishRequiredSetupAsync(): Promise<void> {
         );
     }
 
+    // Check to see if discord URL is set up
+    if (_.isUndefined(constants.discordAlertWebhookUrl)) {
+        throw new Error(
+            'You must have a discord webhook URL set to an envVar named `DISCORD_GITHUB_RELEASE_WEBHOOK_URL`. Add it then try again.',
+        );
+    }
+
     // Check Yarn version is 1.X
     utils.log('Checking the yarn version...');
     const result = await execAsync(`yarn --version`);
diff --git a/packages/monorepo-scripts/src/publish.ts b/packages/monorepo-scripts/src/publish.ts
index 854a72b86..e0602a74f 100644
--- a/packages/monorepo-scripts/src/publish.ts
+++ b/packages/monorepo-scripts/src/publish.ts
@@ -14,6 +14,7 @@ import { constants } from './constants';
 import { Package, PackageToNextVersion, VersionChangelog } from './types';
 import { changelogUtils } from './utils/changelog_utils';
 import { configs } from './utils/configs';
+import { alertDiscordAsync } from './utils/discord';
 import { DocGenerateAndUploadUtils } from './utils/doc_generate_and_upload_utils';
 import { publishReleaseNotesAsync } from './utils/github_release_utils';
 import { utils } from './utils/utils';
@@ -84,7 +85,16 @@ async function confirmAsync(message: string): Promise<void> {
         await generateAndUploadDocJsonsAsync(packagesWithDocs, isStaging, shouldUploadDocs);
     }
     const isDryRun = configs.IS_LOCAL_PUBLISH;
-    await publishReleaseNotesAsync(updatedPublicPackages, isDryRun);
+    const releaseNotes = await publishReleaseNotesAsync(updatedPublicPackages, isDryRun);
+    utils.log('Published release notes');
+
+    if (!isDryRun && releaseNotes) {
+        try {
+            await alertDiscordAsync(releaseNotes);
+        } catch (e) {
+            utils.log("Publish successful, but couldn't auto-alert discord (", e.message, '), Please alert manually.');
+        }
+    }
 })().catch(err => {
     utils.log(err);
     process.exit(1);
diff --git a/packages/monorepo-scripts/src/test_installation.ts b/packages/monorepo-scripts/src/test_installation.ts
index 5ae13b198..822f48967 100644
--- a/packages/monorepo-scripts/src/test_installation.ts
+++ b/packages/monorepo-scripts/src/test_installation.ts
@@ -45,45 +45,50 @@ function logIfDefined(x: any): void {
     const IS_LOCAL_PUBLISH = process.env.IS_LOCAL_PUBLISH === 'true';
     const registry = IS_LOCAL_PUBLISH ? 'http://localhost:4873/' : 'https://registry.npmjs.org/';
     const monorepoRootPath = path.join(__dirname, '../../..');
-    const packages = utils.getPackages(monorepoRootPath);
+    // We sort error messages according to package topology so that we can see
+    // them in a more intuitive order. E.g. if package A has an error and
+    // package B imports it, the tests for both package A and package B will
+    // fail. But package B only fails because of an error in package A.
+    // Since the error in package A is the root cause, we log it first.
+    const packages = utils.getTopologicallySortedPackages(monorepoRootPath);
     const installablePackages = _.filter(
         packages,
         pkg => !pkg.packageJson.private && !_.isUndefined(pkg.packageJson.main) && pkg.packageJson.main.endsWith('.js'),
     );
-    utils.log('Testing packages:');
-    _.map(installablePackages, pkg => utils.log(`* ${pkg.packageJson.name}`));
-    // Run all package tests asynchronously and push promises into an array so
-    // we can wait for all of them to resolve.
-    const promises: Array<Promise<void>> = [];
-    const errors: PackageErr[] = [];
-    for (const installablePackage of installablePackages) {
-        const packagePromise = testInstallPackageAsync(monorepoRootPath, registry, installablePackage).catch(error => {
-            errors.push({ packageName: installablePackage.packageJson.name, error });
-        });
-        promises.push(packagePromise);
-    }
-    await Promise.all(promises);
-    if (errors.length > 0) {
-        // We sort error messages according to package topology so that we can
-        // them in a more intuitive order. E.g. if package A has an error and
-        // package B imports it, the tests for both package A and package B will
-        // fail. But package B only fails because of an error in package A.
-        // Since the error in package A is the root cause, we log it first.
-        const topologicallySortedPackages = utils.getTopologicallySortedPackages(monorepoRootPath);
-        const topologicallySortedErrors = _.sortBy(errors, packageErr =>
-            findPackageIndex(topologicallySortedPackages, packageErr.packageName),
-        );
-        _.forEach(topologicallySortedErrors, packageError => {
-            utils.log(`ERROR in package ${packageError.packageName}:`);
-            logIfDefined(packageError.error.message);
-            logIfDefined(packageError.error.stderr);
-            logIfDefined(packageError.error.stdout);
-            logIfDefined(packageError.error.stack);
-        });
-        process.exit(1);
-    } else {
-        process.exit(0);
+    const CHUNK_SIZE = 15;
+    const chunkedInstallablePackages = _.chunk(installablePackages, CHUNK_SIZE);
+    utils.log(`Testing all packages in ${chunkedInstallablePackages.length} chunks`);
+    for (const installablePackagesChunk of chunkedInstallablePackages) {
+        utils.log('Testing packages:');
+        _.map(installablePackagesChunk, pkg => utils.log(`* ${pkg.packageJson.name}`));
+        // Run all package tests within that chunk asynchronously and push promises into an array so
+        // we can wait for all of them to resolve.
+        const promises: Array<Promise<void>> = [];
+        const errors: PackageErr[] = [];
+        for (const installablePackage of installablePackagesChunk) {
+            const packagePromise = testInstallPackageAsync(monorepoRootPath, registry, installablePackage).catch(
+                error => {
+                    errors.push({ packageName: installablePackage.packageJson.name, error });
+                },
+            );
+            promises.push(packagePromise);
+        }
+        await Promise.all(promises);
+        if (errors.length > 0) {
+            const topologicallySortedErrors = _.sortBy(errors, packageErr =>
+                findPackageIndex(packages, packageErr.packageName),
+            );
+            _.forEach(topologicallySortedErrors, packageError => {
+                utils.log(`ERROR in package ${packageError.packageName}:`);
+                logIfDefined(packageError.error.message);
+                logIfDefined(packageError.error.stderr);
+                logIfDefined(packageError.error.stdout);
+                logIfDefined(packageError.error.stack);
+            });
+            process.exit(1);
+        }
     }
+    process.exit(0);
 })().catch(err => {
     utils.log(`Unexpected error: ${err.message}`);
     process.exit(1);
diff --git a/packages/monorepo-scripts/src/utils/discord.ts b/packages/monorepo-scripts/src/utils/discord.ts
new file mode 100644
index 000000000..3a0458769
--- /dev/null
+++ b/packages/monorepo-scripts/src/utils/discord.ts
@@ -0,0 +1,26 @@
+import { fetchAsync } from '@0x/utils';
+
+import { constants } from '../constants';
+
+import { utils } from './utils';
+
+export const alertDiscordAsync = async (releaseNotes: string): Promise<void> => {
+    const webhookUrl = constants.discordAlertWebhookUrl;
+    if (webhookUrl === undefined) {
+        throw new Error("No discord webhook url, can't alert");
+    }
+
+    utils.log('Alerting discord...');
+    const payload = {
+        content: `New monorepo package released!  View at ${constants.releasesUrl} \n\n ${releaseNotes}`,
+    };
+    await fetchAsync(webhookUrl, {
+        method: 'POST',
+        headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json',
+        },
+        body: JSON.stringify(payload),
+    });
+    return;
+};
diff --git a/packages/monorepo-scripts/src/utils/github_release_utils.ts b/packages/monorepo-scripts/src/utils/github_release_utils.ts
index e63244b46..48704f3aa 100644
--- a/packages/monorepo-scripts/src/utils/github_release_utils.ts
+++ b/packages/monorepo-scripts/src/utils/github_release_utils.ts
@@ -12,7 +12,10 @@ import { utils } from './utils';
 
 const publishReleaseAsync = promisify(publishRelease);
 // tslint:disable-next-line:completed-docs
-export async function publishReleaseNotesAsync(packagesToPublish: Package[], isDryRun: boolean): Promise<void> {
+export async function publishReleaseNotesAsync(
+    packagesToPublish: Package[],
+    isDryRun: boolean,
+): Promise<string | undefined> {
     // Git push a tag representing this publish (publish-{commit-hash}) (truncate hash)
     const result = await execAsync('git log -n 1 --pretty=format:"%H"', { cwd: constants.monorepoRootPath });
     const latestGitCommit = result.stdout;
@@ -75,6 +78,8 @@ export async function publishReleaseNotesAsync(packagesToPublish: Package[], isD
 
     utils.log('Publishing release notes ', releaseName, '...');
     await publishReleaseAsync(publishReleaseConfigs);
+
+    return aggregateNotes;
 }
 
 // Asset paths should described from the monorepo root. This method prefixes