aboutsummaryrefslogtreecommitdiffstats
path: root/packages/react-docs
diff options
context:
space:
mode:
authorFabio B <kandinsky454@protonmail.ch>2018-11-14 03:36:48 +0800
committerGitHub <noreply@github.com>2018-11-14 03:36:48 +0800
commit5c21d3f6af2ffc513b2bbfe92abf99181a32ceca (patch)
tree0ed5f669d7412b002e804d0edd94e10a25bd82cf /packages/react-docs
parenta824264da2d8cbcd76089c5d35da95fedbadd0bb (diff)
parenta4a46dc076f4e491b30671bd9006a586ab9754bc (diff)
downloaddexon-sol-tools-5c21d3f6af2ffc513b2bbfe92abf99181a32ceca.tar.gz
dexon-sol-tools-5c21d3f6af2ffc513b2bbfe92abf99181a32ceca.tar.zst
dexon-sol-tools-5c21d3f6af2ffc513b2bbfe92abf99181a32ceca.zip
Merge pull request #1244 from 0xProject/developerSectionNits
Remaining Developer Section Design Nits
Diffstat (limited to 'packages/react-docs')
-rw-r--r--packages/react-docs/src/components/type.tsx13
-rw-r--r--packages/react-docs/src/docs_info.ts3
2 files changed, 5 insertions, 11 deletions
diff --git a/packages/react-docs/src/components/type.tsx b/packages/react-docs/src/components/type.tsx
index 412b99b9d..fa3b658b4 100644
--- a/packages/react-docs/src/components/type.tsx
+++ b/packages/react-docs/src/components/type.tsx
@@ -1,9 +1,8 @@
-import { colors, constants as sharedConstants, Link, utils as sharedUtils } from '@0x/react-shared';
+import { colors, Link, utils as sharedUtils } from '@0x/react-shared';
import { Type as TypeDef, TypeDefinitionByName, TypeDocTypes } from '@0x/types';
import { errorUtils } from '@0x/utils';
import * as _ from 'lodash';
import * as React from 'react';
-import { Link as ScrollLink } from 'react-scroll';
import * as ReactTooltip from 'react-tooltip';
import { DocsInfo } from '../docs_info';
@@ -224,13 +223,7 @@ export const Type: React.SFC<TypeProps> = (props: TypeProps): any => {
{sharedUtils.isUserOnMobile() || props.isInPopover || isExportedClassReference ? (
<span style={{ color: colors.lightBlueA700, cursor: 'pointer' }}>{typeName}</span>
) : (
- <ScrollLink
- to={typeDefinitionAnchorId}
- offset={0}
- hashSpy={true}
- duration={sharedConstants.DOCS_SCROLL_DURATION_MS}
- containerId={sharedConstants.SCROLL_CONTAINER_ID}
- >
+ <Link to={typeDefinitionAnchorId}>
<span
data-tip={true}
data-for={id}
@@ -252,7 +245,7 @@ export const Type: React.SFC<TypeProps> = (props: TypeProps): any => {
/>
</ReactTooltip>
</span>
- </ScrollLink>
+ </Link>
)}
</span>
);
diff --git a/packages/react-docs/src/docs_info.ts b/packages/react-docs/src/docs_info.ts
index 54b59ef1f..76f7784ba 100644
--- a/packages/react-docs/src/docs_info.ts
+++ b/packages/react-docs/src/docs_info.ts
@@ -10,6 +10,7 @@ import {
SectionsMap,
SupportedDocJson,
} from './types';
+import { constants } from './utils/constants';
export class DocsInfo {
public id: string;
@@ -64,7 +65,7 @@ export class DocsInfo {
const docSections = _.keys(this.sections);
_.each(docSections, sectionName => {
const docSection = docAgnosticFormat[sectionName];
- if (_.isUndefined(docSection)) {
+ if (_.isUndefined(docSection) || sectionName === constants.EXTERNAL_EXPORTS_SECTION_NAME) {
return; // no-op
}