diff options
author | chriseth <chris@ethereum.org> | 2016-09-17 17:28:44 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-09-17 17:28:44 +0800 |
commit | 0bc8476aeaac94f44d85d72865c142ac4151967f (patch) | |
tree | 8543da5568ebcea7f75245619ec5e777c520e7ba | |
parent | 62f13ad8bf1f7f33bc90bb5c1e1b1e001032501d (diff) | |
parent | 031fd568cc753c2ac21e651eaadf2381b2585191 (diff) | |
download | dexon-solidity-0bc8476aeaac94f44d85d72865c142ac4151967f.tar.gz dexon-solidity-0bc8476aeaac94f44d85d72865c142ac4151967f.tar.zst dexon-solidity-0bc8476aeaac94f44d85d72865c142ac4151967f.zip |
Merge pull request #1101 from ethereum/fixcrash
Fix crash for TypeName[k].
-rw-r--r-- | Changelog.md | 8 | ||||
-rw-r--r-- | libsolidity/analysis/TypeChecker.cpp | 2 | ||||
-rw-r--r-- | test/libsolidity/SolidityNameAndTypeResolution.cpp | 10 |
3 files changed, 19 insertions, 1 deletions
diff --git a/Changelog.md b/Changelog.md index 1ae18658..d61ac7c8 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,3 +1,11 @@ +### 0.4.2 + + * Type Checker: Fixed a crash about invalid array types. + +### 0.4.1 (2016-09-09) + + * Build System: Fixes to allow library compilation. + ### 0.4.0 (2016-09-08) This release deliberately breaks backwards compatibility mostly to diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp index d9c54f75..ae7c13c8 100644 --- a/libsolidity/analysis/TypeChecker.cpp +++ b/libsolidity/analysis/TypeChecker.cpp @@ -1438,7 +1438,7 @@ bool TypeChecker::visit(IndexAccess const& _access) length->literalValue(nullptr) )); else - typeError(index->location(), "Integer constant expected."); + fatalTypeError(index->location(), "Integer constant expected."); } break; } diff --git a/test/libsolidity/SolidityNameAndTypeResolution.cpp b/test/libsolidity/SolidityNameAndTypeResolution.cpp index 58736025..b8c64336 100644 --- a/test/libsolidity/SolidityNameAndTypeResolution.cpp +++ b/test/libsolidity/SolidityNameAndTypeResolution.cpp @@ -4009,6 +4009,16 @@ BOOST_AUTO_TEST_CASE(external_constructor) BOOST_CHECK(expectError(text, false) == Error::Type::TypeError); } +BOOST_AUTO_TEST_CASE(invalid_array_as_statement) +{ + char const* text = R"( + contract test { + struct S { uint x; } + function test(uint k) { S[k]; } + } + )"; + BOOST_CHECK(expectError(text, false) == Error::Type::TypeError); +} BOOST_AUTO_TEST_SUITE_END() |