aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorchriseth <chris@ethereum.org>2018-10-15 20:22:17 +0800
committerGitHub <noreply@github.com>2018-10-15 20:22:17 +0800
commit6202628cfe5d1032adeae12153175a78a5596e69 (patch)
treee8d55a903ad067726ede213453edd18134194d5e
parent0778fb2dfca49bd84d202f78e31730c4e930749f (diff)
parent0664772ece60749e606ee94eb073206340cbb08c (diff)
downloaddexon-solidity-6202628cfe5d1032adeae12153175a78a5596e69.tar.gz
dexon-solidity-6202628cfe5d1032adeae12153175a78a5596e69.tar.zst
dexon-solidity-6202628cfe5d1032adeae12153175a78a5596e69.zip
Merge pull request #5221 from ethereum/splitRenamingLeftovers
Some renaming leftovers.
-rw-r--r--libyul/optimiser/ExpressionJoiner.cpp2
-rw-r--r--libyul/optimiser/ExpressionSplitter.cpp4
-rw-r--r--test/libyul/yulOptimizerTests/fullInliner/inside_condition.yul2
3 files changed, 4 insertions, 4 deletions
diff --git a/libyul/optimiser/ExpressionJoiner.cpp b/libyul/optimiser/ExpressionJoiner.cpp
index 3dfab371..c3957497 100644
--- a/libyul/optimiser/ExpressionJoiner.cpp
+++ b/libyul/optimiser/ExpressionJoiner.cpp
@@ -56,7 +56,7 @@ void ExpressionJoiner::operator()(Switch& _switch)
{
visit(*_switch.expression);
for (auto& _case: _switch.cases)
- // Do not visit the case expression, nothing to unbreak there.
+ // Do not visit the case expression, nothing to join there.
(*this)(_case.body);
}
diff --git a/libyul/optimiser/ExpressionSplitter.cpp b/libyul/optimiser/ExpressionSplitter.cpp
index dab0545f..a2ecc546 100644
--- a/libyul/optimiser/ExpressionSplitter.cpp
+++ b/libyul/optimiser/ExpressionSplitter.cpp
@@ -56,14 +56,14 @@ void ExpressionSplitter::operator()(Switch& _switch)
{
outlineExpression(*_switch.expression);
for (auto& _case: _switch.cases)
- // Do not visit the case expression, nothing to break there.
+ // Do not visit the case expression, nothing to split there.
(*this)(_case.body);
}
void ExpressionSplitter::operator()(ForLoop& _loop)
{
(*this)(_loop.pre);
- // Do not visit the condition because we cannot break expressions there.
+ // Do not visit the condition because we cannot split expressions there.
(*this)(_loop.post);
(*this)(_loop.body);
}
diff --git a/test/libyul/yulOptimizerTests/fullInliner/inside_condition.yul b/test/libyul/yulOptimizerTests/fullInliner/inside_condition.yul
index ae25e9a3..76b6054b 100644
--- a/test/libyul/yulOptimizerTests/fullInliner/inside_condition.yul
+++ b/test/libyul/yulOptimizerTests/fullInliner/inside_condition.yul
@@ -1,4 +1,4 @@
-// This tests that breaking the expression inside the condition works properly.
+// This tests that splitting the expression inside the condition works properly.
{
if gt(f(mload(1)), mload(0)) {
sstore(0, 2)