diff options
| author | chriseth <chris@ethereum.org> | 2018-04-19 20:25:46 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-04-19 20:25:46 +0800 |
| commit | 6f0fbcf8b41880c77e8abebb0625ab35290ba2c9 (patch) | |
| tree | 1630f07c0759efe65de67661c33319190ea95ea0 | |
| parent | 6407f1f7bb5f3944eb695517fc3453b701329f4c (diff) | |
| parent | bff741b42f9c5774b3105ff6707e1fd447ec0478 (diff) | |
| download | dexon-solidity-6f0fbcf8b41880c77e8abebb0625ab35290ba2c9.tar.gz dexon-solidity-6f0fbcf8b41880c77e8abebb0625ab35290ba2c9.tar.zst dexon-solidity-6f0fbcf8b41880c77e8abebb0625ab35290ba2c9.zip | |
Merge pull request #3940 from ethereum/remove-old-compiler-flags
Remove old error suppressing compiler flags
| -rw-r--r-- | cmake/EthCompilerSettings.cmake | 33 |
1 files changed, 0 insertions, 33 deletions
diff --git a/cmake/EthCompilerSettings.cmake b/cmake/EthCompilerSettings.cmake index a9ed0a74..c73536ad 100644 --- a/cmake/EthCompilerSettings.cmake +++ b/cmake/EthCompilerSettings.cmake @@ -43,27 +43,6 @@ if (("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU") OR ("${CMAKE_CXX_COMPILER_ID}" MA # TODO - Track down what breaks if we do NOT do this. add_compile_options(-Wno-unknown-pragmas) - # To get the code building on FreeBSD and Arch Linux we seem to need the following - # warning suppression to work around some issues in Boost headers. - # - # See the following reports: - # https://github.com/ethereum/webthree-umbrella/issues/384 - # https://github.com/ethereum/webthree-helpers/pull/170 - # - # The issue manifest as warnings-as-errors like the following: - # - # /usr/local/include/boost/multiprecision/cpp_int.hpp:181:4: error: - # right operand of shift expression '(1u << 63u)' is >= than the precision of the left operand - # - # -fpermissive is a pretty nasty way to address this. It is described as follows: - # - # Downgrade some diagnostics about nonconformant code from errors to warnings. - # Thus, using -fpermissive will allow some nonconforming code to compile. - # - # NB: Have to use this form for the setting, so that it only applies to C++ builds. - # Applying -fpermissive to a C command-line (ie. secp256k1) gives a build error. - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fpermissive") - # Configuration-specific compiler settings. set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g -DETH_DEBUG") set(CMAKE_CXX_FLAGS_MINSIZEREL "-Os -DNDEBUG") @@ -82,18 +61,6 @@ if (("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU") OR ("${CMAKE_CXX_COMPILER_ID}" MA # Additional Clang-specific compiler settings. elseif ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang") - - # A couple of extra warnings suppressions which we seemingly - # need when building with Clang. - # - # TODO - Nail down exactly where these warnings are manifesting and - # try to suppress them in a more localized way. Notes in this file - # indicate that the first is needed for sepc256k1 and that the - # second is needed for the (clog, cwarn) macros. These will need - # testing on at least OS X and Ubuntu. - add_compile_options(-Wno-unused-function) - add_compile_options(-Wno-dangling-else) - if ("${CMAKE_SYSTEM_NAME}" MATCHES "Darwin") # Set stack size to 16MB - by default Apple's clang defines a stack size of 8MB, some tests require more. set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,-stack_size -Wl,0x1000000") |