aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian <c@ethdev.com>2014-11-10 07:42:12 +0800
committerChristian <c@ethdev.com>2014-11-10 07:42:12 +0800
commit91f9a7b7c41a099f2199bb4f62172c98b23120dd (patch)
tree8c398fb82243a4be8360a4ea26aec36cc28d0ef7
parent64a4d77c8b8c559c6e9aad712f7288e4f107e946 (diff)
downloaddexon-solidity-91f9a7b7c41a099f2199bb4f62172c98b23120dd.tar.gz
dexon-solidity-91f9a7b7c41a099f2199bb4f62172c98b23120dd.tar.zst
dexon-solidity-91f9a7b7c41a099f2199bb4f62172c98b23120dd.zip
Do not return after throw.
-rw-r--r--Types.cpp2
-rw-r--r--Types.h6
2 files changed, 3 insertions, 5 deletions
diff --git a/Types.cpp b/Types.cpp
index d861980d..3a4112c4 100644
--- a/Types.cpp
+++ b/Types.cpp
@@ -56,7 +56,6 @@ shared_ptr<Type> Type::fromElementaryTypeName(Token::Value _typeToken)
else
BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Unable to convert elementary typename " +
std::string(Token::toString(_typeToken)) + " to type."));
- return shared_ptr<Type>();
}
shared_ptr<Type> Type::fromUserDefinedTypeName(UserDefinedTypeName const& _typeName)
@@ -67,7 +66,6 @@ shared_ptr<Type> Type::fromUserDefinedTypeName(UserDefinedTypeName const& _typeN
shared_ptr<Type> Type::fromMapping(Mapping const&)
{
BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Mapping types not yet implemented."));
- return shared_ptr<Type>();
}
shared_ptr<Type> Type::forLiteral(Literal const& _literal)
diff --git a/Types.h b/Types.h
index df48418b..607ee3a6 100644
--- a/Types.h
+++ b/Types.h
@@ -201,7 +201,7 @@ public:
virtual bool operator==(Type const& _other) const override;
virtual std::string toString() const override { return "function(...)returns(...)"; }
- virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable function type requested.")); return 1; }
+ virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable function type requested.")); }
private:
FunctionDefinition const& m_function;
@@ -235,7 +235,7 @@ public:
VoidType() {}
virtual std::string toString() const override { return "void"; }
- virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable void type requested.")); return 1; }
+ virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable void type requested.")); }
};
/**
@@ -251,7 +251,7 @@ public:
std::shared_ptr<Type const> const& getActualType() const { return m_actualType; }
virtual bool operator==(Type const& _other) const override;
- virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable type type requested.")); return 1; }
+ virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable type type requested.")); }
virtual std::string toString() const override { return "type(" + m_actualType->toString() + ")"; }
private: