aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Beregszaszi <alex@rtfs.hu>2016-10-06 21:32:11 +0800
committerAlex Beregszaszi <alex@rtfs.hu>2016-10-11 19:28:49 +0800
commitd0791fb365bd90c8d4b4f3ba6f83b126087d9a8e (patch)
tree111ba9c56a3a01bde39447837da8423019f9fce3
parentd3f410d8a89aaa042ff264d7a0ea79184e01abab (diff)
downloaddexon-solidity-d0791fb365bd90c8d4b4f3ba6f83b126087d9a8e.tar.gz
dexon-solidity-d0791fb365bd90c8d4b4f3ba6f83b126087d9a8e.tar.zst
dexon-solidity-d0791fb365bd90c8d4b4f3ba6f83b126087d9a8e.zip
Fix assignment after tags in inline assembly
-rw-r--r--Changelog.md1
-rw-r--r--libsolidity/inlineasm/AsmParser.cpp4
-rw-r--r--test/libsolidity/InlineAssembly.cpp5
3 files changed, 9 insertions, 1 deletions
diff --git a/Changelog.md b/Changelog.md
index 1560990d..bc79b88a 100644
--- a/Changelog.md
+++ b/Changelog.md
@@ -9,6 +9,7 @@ Features:
Bugfixes:
* Disallow unknown options in `solc`
* Inline assembly: support the `address` opcode
+ * Inline assembly: fix parsing of assignment after a label.
### 0.4.2 (2016-09-17)
diff --git a/libsolidity/inlineasm/AsmParser.cpp b/libsolidity/inlineasm/AsmParser.cpp
index ee9c150e..8d2c2ed4 100644
--- a/libsolidity/inlineasm/AsmParser.cpp
+++ b/libsolidity/inlineasm/AsmParser.cpp
@@ -95,7 +95,9 @@ assembly::Statement Parser::parseStatement()
fatalParserError("Label name / variable name must precede \":\".");
assembly::Identifier const& identifier = boost::get<assembly::Identifier>(statement);
m_scanner->next();
- if (m_scanner->currentToken() == Token::Assign)
+ // identifier:=: should be parsed as identifier: =: (i.e. a label),
+ // while identifier:= (being followed by a non-colon) as identifier := (assignment).
+ if (m_scanner->currentToken() == Token::Assign && m_scanner->peekNextToken() != Token::Colon)
{
// functional assignment
FunctionalAssignment funAss = createWithLocation<FunctionalAssignment>(identifier.location);
diff --git a/test/libsolidity/InlineAssembly.cpp b/test/libsolidity/InlineAssembly.cpp
index 136d72e6..45eceb34 100644
--- a/test/libsolidity/InlineAssembly.cpp
+++ b/test/libsolidity/InlineAssembly.cpp
@@ -157,6 +157,11 @@ BOOST_AUTO_TEST_CASE(oversize_string_literals)
BOOST_CHECK(!successAssemble("{ let x := \"123456789012345678901234567890123\" }"));
}
+BOOST_AUTO_TEST_CASE(assignment_after_tag)
+{
+ BOOST_CHECK(successParse("{ let x := 1 { tag: =: x } }"));
+}
+
BOOST_AUTO_TEST_SUITE_END()
}