aboutsummaryrefslogtreecommitdiffstats
path: root/AST.cpp
diff options
context:
space:
mode:
authorChristian <c@ethdev.com>2015-02-09 07:49:35 +0800
committerChristian <c@ethdev.com>2015-02-09 07:49:35 +0800
commit106cda74f8f017d1a463a4bbb8f1309d7647a5d1 (patch)
treeee7343ad6e9d4158252d57153313ce10781f1e68 /AST.cpp
parenta66db516fb1025b406c8fcdb694b7fb760f84695 (diff)
downloaddexon-solidity-106cda74f8f017d1a463a4bbb8f1309d7647a5d1.tar.gz
dexon-solidity-106cda74f8f017d1a463a4bbb8f1309d7647a5d1.tar.zst
dexon-solidity-106cda74f8f017d1a463a4bbb8f1309d7647a5d1.zip
Small cleanup.
Diffstat (limited to 'AST.cpp')
-rw-r--r--AST.cpp20
1 files changed, 9 insertions, 11 deletions
diff --git a/AST.cpp b/AST.cpp
index 6f5b1f38..ab9dccf6 100644
--- a/AST.cpp
+++ b/AST.cpp
@@ -478,7 +478,7 @@ void FunctionCall::checkTypeRequirements()
if (m_arguments.size() != 1)
BOOST_THROW_EXCEPTION(createTypeError("More than one argument for explicit type conversion."));
if (!m_names.empty())
- BOOST_THROW_EXCEPTION(createTypeError("Type conversion can't allow named arguments."));
+ BOOST_THROW_EXCEPTION(createTypeError("Type conversion cannot allow named arguments."));
if (!m_arguments.front()->getType()->isExplicitlyConvertibleTo(*type.getActualType()))
BOOST_THROW_EXCEPTION(createTypeError("Explicit type conversion not allowed."));
m_type = type.getActualType();
@@ -496,24 +496,22 @@ void FunctionCall::checkTypeRequirements()
{
for (size_t i = 0; i < m_arguments.size(); ++i)
if (functionType->getLocation() != FunctionType::Location::SHA3 &&
- !m_arguments[i]->getType()->isImplicitlyConvertibleTo(*parameterTypes[i]))
- BOOST_THROW_EXCEPTION(createTypeError("Invalid type for argument in function call."));
+ !m_arguments[i]->getType()->isImplicitlyConvertibleTo(*parameterTypes[i]))
+ BOOST_THROW_EXCEPTION(m_arguments[i]->createTypeError("Invalid type for argument in function call."));
}
- else if (functionType->getLocation() == FunctionType::Location::SHA3)
- BOOST_THROW_EXCEPTION(createTypeError("Named arguments can't be used for SHA3."));
else
{
+ if (functionType->getLocation() == FunctionType::Location::SHA3)
+ BOOST_THROW_EXCEPTION(createTypeError("Named arguments cannnot be used for SHA3."));
auto const& parameterNames = functionType->getParameterNames();
if (parameterNames.size() != m_names.size())
BOOST_THROW_EXCEPTION(createTypeError("Some argument names are missing."));
// check duplicate names
- for (size_t i = 0; i < m_names.size(); i++) {
- for (size_t j = i + 1; j < m_names.size(); j++) {
+ for (size_t i = 0; i < m_names.size(); i++)
+ for (size_t j = i + 1; j < m_names.size(); j++)
if (*m_names[i] == *m_names[j])
- BOOST_THROW_EXCEPTION(createTypeError("Duplicate named argument."));
- }
- }
+ BOOST_THROW_EXCEPTION(m_arguments[i]->createTypeError("Duplicate named argument."));
for (size_t i = 0; i < m_names.size(); i++) {
bool found = false;
@@ -528,7 +526,7 @@ void FunctionCall::checkTypeRequirements()
}
}
if (!found)
- BOOST_THROW_EXCEPTION(createTypeError("Named argument doesn't match function declaration."));
+ BOOST_THROW_EXCEPTION(createTypeError("Named argument does not match function declaration."));
}
}