aboutsummaryrefslogtreecommitdiffstats
path: root/docs/security-considerations.rst
diff options
context:
space:
mode:
authorChristian Parpart <christian@ethereum.org>2018-06-18 21:58:10 +0800
committerChristian Parpart <christian@ethereum.org>2018-07-03 16:53:09 +0800
commit133fbdbf1874da9bc6b5911430f34a30ccf8db1f (patch)
tree784288777ed6af5f7007a259bf92aa352caa173c /docs/security-considerations.rst
parent1486d215b9c7f94831784ded50342897b65477c9 (diff)
downloaddexon-solidity-133fbdbf1874da9bc6b5911430f34a30ccf8db1f.tar.gz
dexon-solidity-133fbdbf1874da9bc6b5911430f34a30ccf8db1f.tar.zst
dexon-solidity-133fbdbf1874da9bc6b5911430f34a30ccf8db1f.zip
documentation: adjustments to not use the "var" keyword
Diffstat (limited to 'docs/security-considerations.rst')
-rw-r--r--docs/security-considerations.rst3
1 files changed, 1 insertions, 2 deletions
diff --git a/docs/security-considerations.rst b/docs/security-considerations.rst
index c8d8c30b..afdecb98 100644
--- a/docs/security-considerations.rst
+++ b/docs/security-considerations.rst
@@ -103,7 +103,7 @@ outlined further below:
mapping(address => uint) shares;
/// Withdraw your share.
function withdraw() public {
- var share = shares[msg.sender];
+ uint share = shares[msg.sender];
shares[msg.sender] = 0;
msg.sender.transfer(share);
}
@@ -224,7 +224,6 @@ If your wallet had checked ``msg.sender`` for authorization, it would get the ad
Minor Details
=============
-- In ``for (var i = 0; i < arrayName.length; i++) { ... }``, the type of ``i`` will be ``uint8``, because this is the smallest type that is required to hold the value ``0``. If the array has more than 255 elements, the loop will not terminate.
- Types that do not occupy the full 32 bytes might contain "dirty higher order bits".
This is especially important if you access ``msg.data`` - it poses a malleability risk:
You can craft transactions that call a function ``f(uint8 x)`` with a raw byte argument