diff options
| author | chriseth <chris@ethereum.org> | 2018-03-06 16:26:14 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-03-06 16:26:14 +0800 |
| commit | f6c0daec14a047d753c2e501c500995bc7e6dc54 (patch) | |
| tree | fa9b30b3c5d4f5a318f29d4ad382e57db82c897a /libsolidity/analysis/StaticAnalyzer.cpp | |
| parent | a9e02accb96fb1eb39942fa3a68f1904df7ae41d (diff) | |
| parent | 91b13b734d34e6bb5a76fb53624588d035946237 (diff) | |
| download | dexon-solidity-f6c0daec14a047d753c2e501c500995bc7e6dc54.tar.gz dexon-solidity-f6c0daec14a047d753c2e501c500995bc7e6dc54.tar.zst dexon-solidity-f6c0daec14a047d753c2e501c500995bc7e6dc54.zip | |
Merge pull request #3652 from ethereum/gasleft_v2
Use StaticAnalyzer to deprecate msg.gas instead of conditionally remo…
Diffstat (limited to 'libsolidity/analysis/StaticAnalyzer.cpp')
| -rw-r--r-- | libsolidity/analysis/StaticAnalyzer.cpp | 19 |
1 files changed, 18 insertions, 1 deletions
diff --git a/libsolidity/analysis/StaticAnalyzer.cpp b/libsolidity/analysis/StaticAnalyzer.cpp index bd8ee597..d4de219a 100644 --- a/libsolidity/analysis/StaticAnalyzer.cpp +++ b/libsolidity/analysis/StaticAnalyzer.cpp @@ -139,6 +139,23 @@ bool StaticAnalyzer::visit(ExpressionStatement const& _statement) bool StaticAnalyzer::visit(MemberAccess const& _memberAccess) { + bool const v050 = m_currentContract->sourceUnit().annotation().experimentalFeatures.count(ExperimentalFeature::V050); + + if (MagicType const* type = dynamic_cast<MagicType const*>(_memberAccess.expression().annotation().type.get())) + if (type->kind() == MagicType::Kind::Message && _memberAccess.memberName() == "gas") + { + if (v050) + m_errorReporter.typeError( + _memberAccess.location(), + "\"msg.gas\" has been deprecated in favor of \"gasleft()\"" + ); + else + m_errorReporter.warning( + _memberAccess.location(), + "\"msg.gas\" has been deprecated in favor of \"gasleft()\"" + ); + } + if (m_nonPayablePublic && !m_library) if (MagicType const* type = dynamic_cast<MagicType const*>(_memberAccess.expression().annotation().type.get())) if (type->kind() == MagicType::Kind::Message && _memberAccess.memberName() == "value") @@ -151,7 +168,7 @@ bool StaticAnalyzer::visit(MemberAccess const& _memberAccess) if (auto const* type = dynamic_cast<FunctionType const*>(_memberAccess.annotation().type.get())) if (type->kind() == FunctionType::Kind::BareCallCode) { - if (m_currentContract->sourceUnit().annotation().experimentalFeatures.count(ExperimentalFeature::V050)) + if (v050) m_errorReporter.typeError( _memberAccess.location(), "\"callcode\" has been deprecated in favour of \"delegatecall\"." |