diff options
| author | chriseth <chris@ethereum.org> | 2018-03-27 21:47:59 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-03-27 21:47:59 +0800 |
| commit | 62559cf1278afc417d19ec181e2bced364cadea2 (patch) | |
| tree | 9fdc3e2f01c046ec6a29e8c402f11f72625b2e03 /libsolidity/analysis | |
| parent | 8c1352ca7562962b46638da17a293c982bc1dba9 (diff) | |
| parent | 8bae2dba7c9697d129a43c1dde54690f3e37a84a (diff) | |
| download | dexon-solidity-62559cf1278afc417d19ec181e2bced364cadea2.tar.gz dexon-solidity-62559cf1278afc417d19ec181e2bced364cadea2.tar.zst dexon-solidity-62559cf1278afc417d19ec181e2bced364cadea2.zip | |
Merge pull request #3681 from ethereum/interface-external
Allow overriding external functions in interfaces with public in a child
Diffstat (limited to 'libsolidity/analysis')
| -rw-r--r-- | libsolidity/analysis/TypeChecker.cpp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp index 999a2a97..6e287f83 100644 --- a/libsolidity/analysis/TypeChecker.cpp +++ b/libsolidity/analysis/TypeChecker.cpp @@ -378,7 +378,16 @@ void TypeChecker::checkFunctionOverride(FunctionDefinition const& function, Func function.annotation().superFunction = &super; if (function.visibility() != super.visibility()) + { + // visibility is enforced to be external in interfaces, but a contract can override that with public + if ( + super.inContractKind() == ContractDefinition::ContractKind::Interface && + function.inContractKind() != ContractDefinition::ContractKind::Interface && + function.visibility() == FunctionDefinition::Visibility::Public + ) + return; overrideError(function, super, "Overriding function visibility differs."); + } else if (function.stateMutability() != super.stateMutability()) overrideError( |