Prefer mobileType() to check rational range.

2 files changed, 5 insertions, 10 deletions

diff --git a/libsolidity/ast/Types.cpp b/libsolidity/ast/Types.cpp
index 1dbb70e2..c2ebecb5 100644
--- a/libsolidity/ast/Types.cpp
+++ b/libsolidity/ast/Types.cpp
@@ -766,20 +766,15 @@ u256 RationalNumberType::literalValue(Literal const*) const
 TypePointer RationalNumberType::mobileType() const
 {
 	if (m_value.denominator() == 1)
-	{
-		auto intType = integerType();
-		solAssert(!!intType, "mobileType called with invalid integer constant " + toString(false));
-		return intType;
-	}
-	auto fixType = fixedPointType();
-	solAssert(!!fixType, "mobileType called with invalid fixed constant " + toString(false));
-	return fixType;
+		return integerType();
+	else
+		return fixedPointType();
 }
 
 //TODO: combine integerType() and fixedPointType() into one function
 shared_ptr<IntegerType const> RationalNumberType::integerType() const
 {
-	solAssert(m_value.denominator() == 1, "Non integer type found.");
+	solAssert(m_value.denominator() == 1, "integerType() called for fractional number.");
 	bigint value = integerPart();
 	bool negative = (value < 0);
 	if (negative) // convert to positive number of same bit requirements
diff --git a/libsolidity/ast/Types.h b/libsolidity/ast/Types.h
index 5e826684..c3095c97 100644
--- a/libsolidity/ast/Types.h
+++ b/libsolidity/ast/Types.h
@@ -205,7 +205,7 @@ public:
 	virtual unsigned sizeOnStack() const { return 1; }
 	/// @returns the mobile (in contrast to static) type corresponding to the given type.
 	/// This returns the corresponding integer type for ConstantTypes and the pointer type
-	/// for storage reference types.
+	/// for storage reference types. Might return a null pointer if there is no fitting type.
 	virtual TypePointer mobileType() const { return shared_from_this(); }
 	/// @returns true if this is a non-value type and the data of this type is stored at the
 	/// given location.