diff options
| author | Alex Beregszaszi <alex@rtfs.hu> | 2018-04-19 05:22:58 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-04-19 05:22:58 +0800 |
| commit | 39b7b44a8d63c9e50911ba724221b4a6399e7f5e (patch) | |
| tree | 9b78fe43da7ad3b0a68efc43f3df49903c776ea1 /libsolidity | |
| parent | 377254d5a89f3e24cd9c317fdef715101078edff (diff) | |
| parent | 489586430202d17fb60d973503ab27670474143d (diff) | |
| download | dexon-solidity-39b7b44a8d63c9e50911ba724221b4a6399e7f5e.tar.gz dexon-solidity-39b7b44a8d63c9e50911ba724221b4a6399e7f5e.tar.zst dexon-solidity-39b7b44a8d63c9e50911ba724221b4a6399e7f5e.zip | |
Merge pull request #3923 from ethereum/warnConstructor
Warn about functions named "constructor".
Diffstat (limited to 'libsolidity')
| -rw-r--r-- | libsolidity/analysis/SyntaxChecker.cpp | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/libsolidity/analysis/SyntaxChecker.cpp b/libsolidity/analysis/SyntaxChecker.cpp index f648e5b4..396058f4 100644 --- a/libsolidity/analysis/SyntaxChecker.cpp +++ b/libsolidity/analysis/SyntaxChecker.cpp @@ -237,8 +237,13 @@ bool SyntaxChecker::visit(FunctionDefinition const& _function) if (v050) m_errorReporter.syntaxError(_function.location(), "Functions without implementation cannot have modifiers."); else - m_errorReporter.warning( _function.location(), "Modifiers of functions without implementation are ignored." ); + m_errorReporter.warning(_function.location(), "Modifiers of functions without implementation are ignored." ); } + if (_function.name() == "constructor") + m_errorReporter.warning(_function.location(), + "This function is named \"constructor\" but is not the constructor of the contract. " + "If you intend this to be a constructor, use \"constructor(...) { ... }\" without the \"function\" keyword to define it." + ); return true; } |