libsolidity/analysis/StaticAnalyzer.cpp


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85

/*
    This file is part of solidity.

    solidity is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    solidity is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with solidity.  If not, see <http://www.gnu.org/licenses/>.
*/
/**
 * @author Federico Bond <federicobond@gmail.com>
 * @date 2016
 * Static analyzer and checker.
 */

#include <libsolidity/analysis/StaticAnalyzer.h>
#include <memory>
#include <libsolidity/ast/AST.h>

using namespace std;
using namespace dev;
using namespace dev::solidity;


bool StaticAnalyzer::analyze(SourceUnit const& _sourceUnit)
{
    _sourceUnit.accept(*this);
    return Error::containsOnlyWarnings(m_errors);
}

bool StaticAnalyzer::visit(ContractDefinition const& _contract)
{
    m_library = _contract.isLibrary();
    return true;
}

void StaticAnalyzer::endVisit(ContractDefinition const&)
{
    m_library = false;
}

bool StaticAnalyzer::visit(FunctionDefinition const& _function)
{
    m_nonPayablePublic = _function.isPublic() && !_function.isPayable();
    return true;
}

void StaticAnalyzer::endVisit(FunctionDefinition const&)
{
    m_nonPayablePublic = false;
}

bool StaticAnalyzer::visit(ExpressionStatement const& _statement)
{
    if (_statement.expression().annotation().isPure)
        warning(_statement.location(), "Statement has no effect.");
    return true;
}

bool StaticAnalyzer::visit(MemberAccess const& _memberAccess)
{
    if (m_nonPayablePublic && !m_library)
        if (MagicType const* type = dynamic_cast<MagicType const*>(_memberAccess.expression().annotation().type.get()))
            if (type->kind() == MagicType::Kind::Message && _memberAccess.memberName() == "value")
                warning(_memberAccess.location(), "\"msg.value\" used in non-payable function. Do you want to add the \"payable\" modifier to this function?");

    return true;
}

void StaticAnalyzer::warning(SourceLocation const& _location, string const& _description)
{
    auto err = make_shared<Error>(Error::Type::Warning);
    *err <<
        errinfo_sourceLocation(_location) <<
        errinfo_comment(_description);

    m_errors.push_back(err);
}