path: root/libsolidity/analysis/SyntaxChecker.cpp

/*
    This file is part of solidity.

    solidity is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    solidity is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with solidity.  If not, see <http://www.gnu.org/licenses/>.
*/

#include <libsolidity/analysis/SyntaxChecker.h>
#include <memory>
#include <libsolidity/ast/AST.h>
#include <libsolidity/ast/ExperimentalFeatures.h>
#include <libsolidity/analysis/SemVerHandler.h>
#include <libsolidity/interface/ErrorReporter.h>
#include <libsolidity/interface/Version.h>

using namespace std;
using namespace dev;
using namespace dev::solidity;


bool SyntaxChecker::checkSyntax(ASTNode const& _astRoot)
{
    _astRoot.accept(*this);
    return Error::containsOnlyWarnings(m_errorReporter.errors());
}

bool SyntaxChecker::visit(SourceUnit const& _sourceUnit)
{
    m_versionPragmaFound = false;
    m_sourceUnit = &_sourceUnit;
    return true;
}

void SyntaxChecker::endVisit(SourceUnit const& _sourceUnit)
{
    if (!m_versionPragmaFound)
    {
        string errorString("Source file does not specify required compiler version!");
        SemVerVersion recommendedVersion{string(VersionString)};
        if (!recommendedVersion.isPrerelease())
            errorString +=
                "Consider adding \"pragma solidity ^" +
                to_string(recommendedVersion.major()) +
                string(".") +
                to_string(recommendedVersion.minor()) +
                string(".") +
                to_string(recommendedVersion.patch()) +
                string(";\"");

        m_errorReporter.warning(_sourceUnit.location(), errorString);
    }
    m_sourceUnit = nullptr;
}

bool SyntaxChecker::visit(PragmaDirective const& _pragma)
{
    solAssert(!_pragma.tokens().empty(), "");
    solAssert(_pragma.tokens().size() == _pragma.literals().size(), "");
    if (_pragma.tokens()[0] != Token::Identifier)
        m_errorReporter.syntaxError(_pragma.location(), "Invalid pragma \"" + _pragma.literals()[0] + "\"");
    else if (_pragma.literals()[0] == "experimental")
    {
        solAssert(m_sourceUnit, "");
        vector<string> literals(_pragma.literals().begin() + 1, _pragma.literals().end());
        if (literals.size() == 0)
            m_errorReporter.syntaxError(
                _pragma.location(),
                "Experimental feature name is missing."
            );
        else if (literals.size() > 1)
            m_errorReporter.syntaxError(
                _pragma.location(),
                "Stray arguments."
            );
        else
        {
            string const literal = literals[0];
            if (literal.empty())
                m_errorReporter.syntaxError(_pragma.location(), "Empty experimental feature name is invalid.");
            else if (!ExperimentalFeatureNames.count(literal))
                m_errorReporter.syntaxError(_pragma.location(), "Unsupported experimental feature name.");
            else if (m_sourceUnit->annotation().experimentalFeatures.count(ExperimentalFeatureNames.at(literal)))
                m_errorReporter.syntaxError(_pragma.location(), "Duplicate experimental feature name.");
            else
            {
                auto feature = ExperimentalFeatureNames.at(literal);
                m_sourceUnit->annotation().experimentalFeatures.insert(feature);
                if (!ExperimentalFeatureOnlyAnalysis.count(feature))
                    m_errorReporter.warning(_pragma.location(), "Experimental features are turned on. Do not use experimental features on live deployments.");
            }
        }
    }
    else if (_pragma.literals()[0] == "solidity")
    {
        vector<Token::Value> tokens(_pragma.tokens().begin() + 1, _pragma.tokens().end());
        vector<string> literals(_pragma.literals().begin() + 1, _pragma.literals().end());
        SemVerMatchExpressionParser parser(tokens, literals);
        auto matchExpression = parser.parse();
        SemVerVersion currentVersion{string(VersionString)};
        if (!matchExpression.matches(currentVersion))
            m_errorReporter.syntaxError(
                _pragma.location(),
                "Source file requires different compiler version (current compiler is " +
                string(VersionString) + " - note that nightly builds are considered to be "
                "strictly less than the released version"
            );
        m_versionPragmaFound = true;
    }
    else
        m_errorReporter.syntaxError(_pragma.location(), "Unknown pragma \"" + _pragma.literals()[0] + "\"");
    return true;
}

bool SyntaxChecker::visit(ModifierDefinition const&)
{
    m_placeholderFound = false;
    return true;
}

void SyntaxChecker::endVisit(ModifierDefinition const& _modifier)
{
    if (!m_placeholderFound)
        m_errorReporter.syntaxError(_modifier.body().location(), "Modifier body does not contain '_'.");
    m_placeholderFound = false;
}

bool SyntaxChecker::visit(WhileStatement const&)
{
    m_inLoopDepth++;
    return true;
}

void SyntaxChecker::endVisit(WhileStatement const&)
{
    m_inLoopDepth--;
}

bool SyntaxChecker::visit(ForStatement const&)
{
    m_inLoopDepth++;
    return true;
}

void SyntaxChecker::endVisit(ForStatement const&)
{
    m_inLoopDepth--;
}

bool SyntaxChecker::visit(Continue const& _continueStatement)
{
    if (m_inLoopDepth <= 0)
        // we're not in a for/while loop, report syntax error
        m_errorReporter.syntaxError(_continueStatement.location(), "\"continue\" has to be in a \"for\" or \"while\" loop.");
    return true;
}

bool SyntaxChecker::visit(Break const& _breakStatement)
{
    if (m_inLoopDepth <= 0)
        // we're not in a for/while loop, report syntax error
        m_errorReporter.syntaxError(_breakStatement.location(), "\"break\" has to be in a \"for\" or \"while\" loop.");
    return true;
}

bool SyntaxChecker::visit(Throw const& _throwStatement)
{
    bool const v050 = m_sourceUnit->annotation().experimentalFeatures.count(ExperimentalFeature::V050);

    if (v050)
        m_errorReporter.syntaxError(
            _throwStatement.location(),
            "\"throw\" is deprecated in favour of \"revert()\", \"require()\" and \"assert()\"."
        );
    else
        m_errorReporter.warning(
            _throwStatement.location(),
            "\"throw\" is deprecated in favour of \"revert()\", \"require()\" and \"assert()\"."
        );

    return true;
}

bool SyntaxChecker::visit(UnaryOperation const& _operation)
{
    bool const v050 = m_sourceUnit->annotation().experimentalFeatures.count(ExperimentalFeature::V050);

    if (_operation.getOperator() == Token::Add)
    {
        if (v050)
            m_errorReporter.syntaxError(_operation.location(), "Use of unary + is deprecated.");
        else
            m_errorReporter.warning(_operation.location(), "Use of unary + is deprecated.");
    }
    return true;
}

bool SyntaxChecker::visit(PlaceholderStatement const&)
{
    m_placeholderFound = true;
    return true;
}

bool SyntaxChecker::visit(FunctionDefinition const& _function)
{
    bool const v050 = m_sourceUnit->annotation().experimentalFeatures.count(ExperimentalFeature::V050);

    if (v050 && _function.noVisibilitySpecified())
        m_errorReporter.syntaxError(_function.location(), "No visibility specified.");

    if (_function.isOldStyleConstructor())
    {
        if (v050)
            m_errorReporter.syntaxError(
                _function.location(),
                "Functions are not allowed to have the same name as the contract. "
                "If you intend this to be a constructor, use \"constructor(...) { ... }\" to define it."
            );
        else
            m_errorReporter.warning(
                _function.location(),
                "Defining constructors as functions with the same name as the contract is deprecated. "
                "Use \"constructor(...) { ... }\" instead."
            );
    }
    if (!_function.isImplemented() && !_function.modifiers().empty())
    {
        if (v050)
            m_errorReporter.syntaxError(_function.location(), "Functions without implementation cannot have modifiers.");
        else
            m_errorReporter.warning(_function.location(), "Modifiers of functions without implementation are ignored." );
    }
    if (_function.name() == "constructor")
        m_errorReporter.warning(_function.location(),
            "This function is named \"constructor\" but is not the constructor of the contract. "
            "If you intend this to be a constructor, use \"constructor(...) { ... }\" without the \"function\" keyword to define it."
        );
    return true;
}

bool SyntaxChecker::visit(FunctionTypeName const& _node)
{
    for (auto const& decl: _node.parameterTypeList()->parameters())
        if (!decl->name().empty())
            m_errorReporter.warning(decl->location(), "Naming function type parameters is deprecated.");

    for (auto const& decl: _node.returnParameterTypeList()->parameters())
        if (!decl->name().empty())
            m_errorReporter.syntaxError(decl->location(), "Return parameters in function types may not be named.");

    return true;
}

bool SyntaxChecker::visit(VariableDeclaration const& _declaration)
{
    bool const v050 = m_sourceUnit->annotation().experimentalFeatures.count(ExperimentalFeature::V050);

    if (!_declaration.typeName())
    {
        if (v050)
            m_errorReporter.syntaxError(_declaration.location(), "Use of the \"var\" keyword is deprecated.");
        else
            m_errorReporter.warning(_declaration.location(), "Use of the \"var\" keyword is deprecated.");
    }
    return true;
}

bool SyntaxChecker::visit(StructDefinition const& _struct)
{
    if (_struct.members().empty())
        m_errorReporter.syntaxError(_struct.location(), "Defining empty structs is disallowed.");

    return true;
}