aboutsummaryrefslogtreecommitdiffstats
path: root/test/libsolidity/ViewPureChecker.cpp
blob: 53761ff2f0464e131d7cff1633f9d0937734427a (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
/*
    This file is part of solidity.

    solidity is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    solidity is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with solidity.  If not, see <http://www.gnu.org/licenses/>.
*/
/**
 * Unit tests for the view and pure checker.
 */

#include <test/libsolidity/AnalysisFramework.h>

#include <test/Options.h>

#include <boost/test/unit_test.hpp>

#include <string>
#include <tuple>

using namespace std;

namespace dev
{
namespace solidity
{
namespace test
{

BOOST_FIXTURE_TEST_SUITE(ViewPureChecker, AnalysisFramework)

BOOST_AUTO_TEST_CASE(environment_access)
{
    vector<string> view{
        "block.coinbase",
        "block.timestamp",
        "block.blockhash(7)",
        "block.difficulty",
        "block.number",
        "block.gaslimit",
        "blockhash(7)",
        "gasleft()",
        "msg.gas",
        "msg.value",
        "msg.sender",
        "tx.origin",
        "tx.gasprice",
        "this",
        "address(1).balance"
    };
    // ``block.blockhash`` and ``blockhash`` are tested seperately below because their usage will
    // produce warnings that can't be handled in a generic way.
    vector<string> pure{
        "msg.data",
        "msg.data[0]",
        "msg.sig",
        "msg",
        "block",
        "tx"
    };
    for (string const& x: view)
    {
        CHECK_ERROR(
            "contract C { function f() pure public { " + x + "; } }",
            TypeError,
            "Function declared as pure, but this expression (potentially) reads from the environment or state and thus requires \"view\""
        );
    }
    for (string const& x: pure)
    {
        CHECK_WARNING(
            "contract C { function f() view public { " + x + "; } }",
            "Function state mutability can be restricted to pure"
        );
    }

    CHECK_WARNING_ALLOW_MULTI(
        "contract C { function f() view public { blockhash; } }",
        (std::vector<std::string>{
            "Function state mutability can be restricted to pure",
            "Statement has no effect."
    }));

    CHECK_WARNING_ALLOW_MULTI(
        "contract C { function f() view public { block.blockhash; } }",
        (std::vector<std::string>{
            "Function state mutability can be restricted to pure",
            "\"block.blockhash()\" has been deprecated in favor of \"blockhash()\""
    }));
}

BOOST_AUTO_TEST_CASE(assembly_staticcall)
{
    string text = R"(
        contract C {
            function i() view public {
                assembly { pop(staticcall(gas, 1, 2, 3, 4, 5)) }
            }
        }
    )";
    if (!dev::test::Options::get().evmVersion().hasStaticCall())
        CHECK_WARNING(text, "\"staticcall\" instruction is only available for Byzantium-compatible");
    else
        CHECK_SUCCESS_NO_WARNINGS(text);
}

BOOST_AUTO_TEST_SUITE_END()

}
}
}