diff options
| author | Felix Lange <fjl@users.noreply.github.com> | 2017-02-28 22:09:11 +0800 |
|---|---|---|
| committer | Jeffrey Wilcke <jeffrey@ethereum.org> | 2017-02-28 22:09:11 +0800 |
| commit | 5f7826270c9e87509fd7731ec64953a5e4761de0 (patch) | |
| tree | 0d3187b115a0e10afcce1bb38ed8ba977d8bf44f /crypto/secp256k1/curve.go | |
| parent | d4f60d362b8fcf82db1accf89c146a2a71375841 (diff) | |
| download | dexon-5f7826270c9e87509fd7731ec64953a5e4761de0.tar.gz dexon-5f7826270c9e87509fd7731ec64953a5e4761de0.tar.zst dexon-5f7826270c9e87509fd7731ec64953a5e4761de0.zip | |
all: unify big.Int zero checks, use common/math in more places (#3716)
* common/math: optimize PaddedBigBytes, use it more
name old time/op new time/op delta
PaddedBigBytes-8 71.1ns ± 5% 46.1ns ± 1% -35.15% (p=0.000 n=20+19)
name old alloc/op new alloc/op delta
PaddedBigBytes-8 48.0B ± 0% 32.0B ± 0% -33.33% (p=0.000 n=20+20)
* all: unify big.Int zero checks
Various checks were in use. This commit replaces them all with Int.Sign,
which is cheaper and less code.
eg templates:
func before(x *big.Int) bool { return x.BitLen() == 0 }
func after(x *big.Int) bool { return x.Sign() == 0 }
func before(x *big.Int) bool { return x.BitLen() > 0 }
func after(x *big.Int) bool { return x.Sign() != 0 }
func before(x *big.Int) int { return x.Cmp(common.Big0) }
func after(x *big.Int) int { return x.Sign() }
* common/math, crypto/secp256k1: make ReadBits public in package math
Diffstat (limited to 'crypto/secp256k1/curve.go')
| -rw-r--r-- | crypto/secp256k1/curve.go | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/crypto/secp256k1/curve.go b/crypto/secp256k1/curve.go index 61cad5463..ec6d266ce 100644 --- a/crypto/secp256k1/curve.go +++ b/crypto/secp256k1/curve.go @@ -36,6 +36,8 @@ import ( "math/big" "sync" "unsafe" + + "github.com/ethereum/go-ethereum/common/math" ) /* @@ -230,8 +232,8 @@ func (BitCurve *BitCurve) ScalarMult(Bx, By *big.Int, scalar []byte) (*big.Int, // Do the multiplication in C, updating point. point := make([]byte, 64) - readBits(point[:32], Bx) - readBits(point[32:], By) + math.ReadBits(Bx, point[:32]) + math.ReadBits(By, point[32:]) pointPtr := (*C.uchar)(unsafe.Pointer(&point[0])) scalarPtr := (*C.uchar)(unsafe.Pointer(&scalar[0])) res := C.secp256k1_pubkey_scalar_mul(context, pointPtr, scalarPtr) |