signer: fix golint errors (#16653)

* signer/*: golint fixes

Specifically naming and comment formatting for documentation

* signer/*: fixed naming error crashing build

* signer/*: corrected error

* signer/core: fix tiny error whitespace

* signer/rules: fix test refactor

5 files changed, 11 insertions, 11 deletions

diff --git a/signer/core/abihelper.go b/signer/core/abihelper.go
index 2674c7346..1d4fbc7dc 100644
--- a/signer/core/abihelper.go
+++ b/signer/core/abihelper.go
@@ -94,13 +94,12 @@ func parseCallData(calldata []byte, abidata string) (*decodedCallData, error) {
 	for n, argument := range method.Inputs {
 		if err != nil {
 			return nil, fmt.Errorf("Failed to decode argument %d (signature %v): %v", n, method.Sig(), err)
-		} else {
-			decodedArg := decodedArgument{
-				soltype: argument,
-				value:   v[n],
-			}
-			decoded.inputs = append(decoded.inputs, decodedArg)
 		}
+		decodedArg := decodedArgument{
+			soltype: argument,
+			value:   v[n],
+		}
+		decoded.inputs = append(decoded.inputs, decodedArg)
 	}
 
 	// We're finished decoding the data. At this point, we encode the decoded data to see if it matches with the
@@ -240,7 +239,7 @@ func (db *AbiDb) saveCustomAbi(selector, signature string) error {
 	return err
 }
 
-// Adds a signature to the database, if custom database saving is enabled.
+// AddSignature to the database, if custom database saving is enabled.
 // OBS: This method does _not_ validate the correctness of the data,
 // it is assumed that the caller has already done so
 func (db *AbiDb) AddSignature(selector string, data []byte) error {
diff --git a/signer/core/api.go b/signer/core/api.go
index 1387041cc..45933284b 100644
--- a/signer/core/api.go
+++ b/signer/core/api.go
@@ -474,7 +474,7 @@ func (api *SignerAPI) Export(ctx context.Context, addr common.Address) (json.Raw
 	return ioutil.ReadFile(wallet.URL().Path)
 }
 
-// Imports tries to import the given keyJSON in the local keystore. The keyJSON data is expected to be
+// Import tries to import the given keyJSON in the local keystore. The keyJSON data is expected to be
 // in web3 keystore format. It will decrypt the keyJSON with the given passphrase and on successful
 // decryption it will encrypt the key with the given newPassphrase and store it in the keystore.
 func (api *SignerAPI) Import(ctx context.Context, keyJSON json.RawMessage) (Account, error) {
diff --git a/signer/core/cliui.go b/signer/core/cliui.go
index 0d9b5f3d3..2f969669c 100644
--- a/signer/core/cliui.go
+++ b/signer/core/cliui.go
@@ -13,6 +13,7 @@
 //
 // You should have received a copy of the GNU General Public License
 // along with go-ethereum. If not, see <http://www.gnu.org/licenses/>.
+
 package core
 
 import (
diff --git a/signer/core/types.go b/signer/core/types.go
index 8386bd44e..2acc0a4f4 100644
--- a/signer/core/types.go
+++ b/signer/core/types.go
@@ -73,8 +73,8 @@ type SendTxArgs struct {
 	Input *hexutil.Bytes `json:"input"`
 }
 
-func (t SendTxArgs) String() string {
-	s, err := json.Marshal(t)
+func (args SendTxArgs) String() string {
+	s, err := json.Marshal(args)
 	if err == nil {
 		return string(s)
 	}
diff --git a/signer/core/validation.go b/signer/core/validation.go
index 97bb3b685..288456df8 100644
--- a/signer/core/validation.go
+++ b/signer/core/validation.go
@@ -128,7 +128,7 @@ func (v *Validator) validate(msgs *ValidationMessages, txargs *SendTxArgs, metho
 		if len(data) == 0 {
 			if txargs.Value.ToInt().Cmp(big.NewInt(0)) > 0 {
 				// Sending ether into black hole
-				return errors.New(`Tx will create contract with value but empty code!`)
+				return errors.New("Tx will create contract with value but empty code!")
 			}
 			// No value submitted at least
 			msgs.crit("Tx will create contract with empty code!")