aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRodrigo Moya <rodrigo@novell.com>2004-06-03 00:31:23 +0800
committerRodrigo Moya <rodrigo@src.gnome.org>2004-06-03 00:31:23 +0800
commit5919bc5b8bcf8d9254db4aa3379ce7693ceb26d9 (patch)
treea240866ef3612f11af2ffb1f1039372130cc78f2
parent81a9c1e88d1c08fd59c6492686b45d53919a99b6 (diff)
downloadgsoc2013-evolution-5919bc5b8bcf8d9254db4aa3379ce7693ceb26d9.tar.gz
gsoc2013-evolution-5919bc5b8bcf8d9254db4aa3379ce7693ceb26d9.tar.zst
gsoc2013-evolution-5919bc5b8bcf8d9254db4aa3379ce7693ceb26d9.zip
fixed leak and pass the correct icalcomponent to e_cal_modify_object.
2004-06-02 Rodrigo Moya <rodrigo@novell.com> * gui/dialogs/copy-source-dialog.c (copy_source): fixed leak and pass the correct icalcomponent to e_cal_modify_object. svn path=/trunk/; revision=26154
-rw-r--r--calendar/ChangeLog5
-rw-r--r--calendar/gui/dialogs/copy-source-dialog.c3
-rw-r--r--calendar/gui/dialogs/event-editor.c4
-rw-r--r--calendar/gui/e-itip-control.c5
4 files changed, 11 insertions, 6 deletions
diff --git a/calendar/ChangeLog b/calendar/ChangeLog
index 5a9311f8a4..589f7ef797 100644
--- a/calendar/ChangeLog
+++ b/calendar/ChangeLog
@@ -1,5 +1,10 @@
2004-06-02 Rodrigo Moya <rodrigo@novell.com>
+ * gui/dialogs/copy-source-dialog.c (copy_source): fixed
+ leak and pass the correct icalcomponent to e_cal_modify_object.
+
+2004-06-02 Rodrigo Moya <rodrigo@novell.com>
+
Fixes #59333
* gui/dialogs/task-page.c (task_page_fill_widgets): guard against
diff --git a/calendar/gui/dialogs/copy-source-dialog.c b/calendar/gui/dialogs/copy-source-dialog.c
index dca36f0771..7d20240334 100644
--- a/calendar/gui/dialogs/copy-source-dialog.c
+++ b/calendar/gui/dialogs/copy-source-dialog.c
@@ -83,7 +83,8 @@ copy_source (CopySourceDialogData *csdd)
/* FIXME: process errors */
if (e_cal_get_object (dest_client, icalcomponent_get_uid (l->data), NULL,
&icalcomp, NULL)) {
- e_cal_modify_object (dest_client, icalcomp, CALOBJ_MOD_ALL, NULL);
+ e_cal_modify_object (dest_client, l->data, CALOBJ_MOD_ALL, NULL);
+ icalcomponent_free (icalcomp);
} else {
e_cal_create_object (dest_client, l->data, (char **) &uid, NULL);
g_free ((gpointer) uid);
diff --git a/calendar/gui/dialogs/event-editor.c b/calendar/gui/dialogs/event-editor.c
index 7dee1c54d6..f8197b5f85 100644
--- a/calendar/gui/dialogs/event-editor.c
+++ b/calendar/gui/dialogs/event-editor.c
@@ -132,7 +132,7 @@ set_menu_sens (EventEditor *ee)
e_cal_is_read_only (comp_editor_get_e_cal (COMP_EDITOR (ee)), &read_only, NULL);
sens = priv->meeting_shown;
- comp_editor_set_ui_prop (COMP_EDITOR (ee),
+ comp_editor_set_ui_prop (COMP_EDITOR (ee),
"/commands/ActionScheduleMeeting",
"sensitive", sens || read_only ? "0" : "1");
@@ -144,7 +144,7 @@ set_menu_sens (EventEditor *ee)
sens = priv->meeting_shown && existing && user && !read_only;
comp_editor_set_ui_prop (COMP_EDITOR (ee),
"/commands/ActionCancelMeeting",
- "sensitive", sens? "1" : "0");
+ "sensitive", sens ? "1" : "0");
comp_editor_set_ui_prop (COMP_EDITOR (ee),
"/commands/FileSave",
diff --git a/calendar/gui/e-itip-control.c b/calendar/gui/e-itip-control.c
index 5027e3953c..ad0503001a 100644
--- a/calendar/gui/e-itip-control.c
+++ b/calendar/gui/e-itip-control.c
@@ -183,7 +183,7 @@ find_server (EItipControl *itip, ECalComponent *comp)
GSList *sources, *m;
group = l->data;
-
+
sources = e_source_group_peek_sources (group);
for (m = sources; m; m = m->next) {
ESource *source;
@@ -384,8 +384,7 @@ find_my_address (EItipControl *itip, icalcomponent *ical_comp)
for (prop = icalcomponent_get_first_property (ical_comp, ICAL_ATTENDEE_PROPERTY);
prop != NULL;
- prop = icalcomponent_get_next_property (ical_comp, ICAL_ATTENDEE_PROPERTY))
- {
+ prop = icalcomponent_get_next_property (ical_comp, ICAL_ATTENDEE_PROPERTY)) {
icalvalue *value;
icalparameter *param;
const char *attendee, *name;