aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Toshok <toshok@ximian.com>2002-12-19 08:04:04 +0800
committerChris Toshok <toshok@src.gnome.org>2002-12-19 08:04:04 +0800
commit7bd2b9cf14e7f0bf211aab839342523cf6f21752 (patch)
treec242eb650b75fac3eca48a5e14eef3616a7c3db0
parentf38991684d7f25a0305ff383c8956a8b7b1c11ae (diff)
downloadgsoc2013-evolution-7bd2b9cf14e7f0bf211aab839342523cf6f21752.tar.gz
gsoc2013-evolution-7bd2b9cf14e7f0bf211aab839342523cf6f21752.tar.zst
gsoc2013-evolution-7bd2b9cf14e7f0bf211aab839342523cf6f21752.zip
[ fixes bug #34897 ] don't free the return of e_card_simple_get_const, as
2002-12-17 Chris Toshok <toshok@ximian.com> [ fixes bug #34897 ] * gui/widgets/e-addressbook-table-adapter.c (addressbook_value_at): don't free the return of e_card_simple_get_const, as this causes a double free later on. svn path=/trunk/; revision=19163
-rw-r--r--addressbook/ChangeLog7
-rw-r--r--addressbook/gui/widgets/e-addressbook-table-adapter.c2
2 files changed, 8 insertions, 1 deletions
diff --git a/addressbook/ChangeLog b/addressbook/ChangeLog
index e868df8092..f86dce89f0 100644
--- a/addressbook/ChangeLog
+++ b/addressbook/ChangeLog
@@ -1,3 +1,10 @@
+2002-12-17 Chris Toshok <toshok@ximian.com>
+
+ [ fixes bug #34897 ]
+ * gui/widgets/e-addressbook-table-adapter.c
+ (addressbook_value_at): don't free the return of
+ e_card_simple_get_const, as this causes a double free later on.
+
2002-12-18 Chris Toshok <toshok@ximian.com>
* gui/component/e-address-popup.c: convert the clist in here to a
diff --git a/addressbook/gui/widgets/e-addressbook-table-adapter.c b/addressbook/gui/widgets/e-addressbook-table-adapter.c
index 5f09727ee0..6146aa75f3 100644
--- a/addressbook/gui/widgets/e-addressbook-table-adapter.c
+++ b/addressbook/gui/widgets/e-addressbook-table-adapter.c
@@ -122,7 +122,7 @@ addressbook_value_at (ETableModel *etc, int col, int row)
if (value && !strncmp (value, "<?xml", 5)) {
EDestination *dest = e_destination_import (value);
if (dest) {
- g_free ((gchar *) value);
+ /* XXX blech, we leak this */
value = g_strdup (e_destination_get_address (dest));
g_object_unref (dest);
}