aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVivek Jain <jvivek@novell.com>2005-07-11 14:36:29 +0800
committerJain Vivek <jvivek@src.gnome.org>2005-07-11 14:36:29 +0800
commitfe3b0cf30499eb12103dcc1c995cbc4dc1afc069 (patch)
tree9a4ea26e7003b73b71b36d18305cbd70dff50483
parent45057ab2e503cba209411f7dcf87fb200e3b01ed (diff)
downloadgsoc2013-evolution-fe3b0cf30499eb12103dcc1c995cbc4dc1afc069.tar.gz
gsoc2013-evolution-fe3b0cf30499eb12103dcc1c995cbc4dc1afc069.tar.zst
gsoc2013-evolution-fe3b0cf30499eb12103dcc1c995cbc4dc1afc069.zip
check whether memory could be allocated. Return if the message is NULL so
2005-07-11 Vivek Jain <jvivek@novell.com> * new-mail-notify.c :(send_dbus_message) check whether memory could be allocated. Return if the message is NULL so that we don't unref it again, will save crash. **Fixes #274329 sort of bugs, in case reported even after david's fix. svn path=/trunk/; revision=29705
-rw-r--r--plugins/new-mail-notify/ChangeLog8
-rw-r--r--plugins/new-mail-notify/new-mail-notify.c3
2 files changed, 11 insertions, 0 deletions
diff --git a/plugins/new-mail-notify/ChangeLog b/plugins/new-mail-notify/ChangeLog
index 7e1a61ee49..043f38e422 100644
--- a/plugins/new-mail-notify/ChangeLog
+++ b/plugins/new-mail-notify/ChangeLog
@@ -1,3 +1,11 @@
+2005-07-11 Vivek Jain <jvivek@novell.com>
+
+ * new-mail-notify.c :(send_dbus_message)
+ check whether memory could be allocated. Return if the
+ message is NULL so that we don't unref it again, will save crash.
+ **Fixes #274329 sort of bugs, in case reported even after
+ david's fix.
+
2005-05-11 Not Zed <NotZed@Ximian.com>
* Makefile.am: added built_sources/cleanfiles
diff --git a/plugins/new-mail-notify/new-mail-notify.c b/plugins/new-mail-notify/new-mail-notify.c
index 872fa80c62..dba602acf0 100644
--- a/plugins/new-mail-notify/new-mail-notify.c
+++ b/plugins/new-mail-notify/new-mail-notify.c
@@ -57,6 +57,9 @@ send_dbus_message (const char *message_name, const char *data)
DBUS_INTERFACE,
message_name);
+ if (message == NULL)
+ return;
+
/* Appends the data as an argument to the message */
dbus_message_append_args (message,
#if DBUS_VERSION >= 310