diff options
| author | Christopher James Lahey <clahey@helixcode.com> | 2000-03-29 09:38:45 +0800 |
|---|---|---|
| committer | Chris Lahey <clahey@src.gnome.org> | 2000-03-29 09:38:45 +0800 |
| commit | 68b4d99fcb3d2ddf45cf0c004d3a0bac341f9616 (patch) | |
| tree | 103ed00062df4872d4f3daf165523a91866bce5a /addressbook/backend/pas | |
| parent | b88b59741fd9d2bc4097b803db4447e15d004d79 (diff) | |
| download | gsoc2013-evolution-68b4d99fcb3d2ddf45cf0c004d3a0bac341f9616.tar.gz gsoc2013-evolution-68b4d99fcb3d2ddf45cf0c004d3a0bac341f9616.tar.zst gsoc2013-evolution-68b4d99fcb3d2ddf45cf0c004d3a0bac341f9616.zip | |
Fixed memory allocation.
2000-03-28 Christopher James Lahey <clahey@helixcode.com>
* addressbook/backend/pas/pas-card-cursor.c: Fixed memory
allocation.
* addressbook/backend/pas/pas-backend-file.c: Fixed memory
allocation. Made database stuff not do an extra entry.
* addressbook/backend/ebook/test-client.c: Add test for
get_all_cards functionality. Changed database name to test.db.
* addressbook/backend/ebook/e-card-cursor.c: Changed bonobo_object
to gtk_object in a couple of places.
svn path=/trunk/; revision=2236
Diffstat (limited to 'addressbook/backend/pas')
| -rw-r--r-- | addressbook/backend/pas/pas-backend-file.c | 23 | ||||
| -rw-r--r-- | addressbook/backend/pas/pas-card-cursor.c | 11 |
2 files changed, 20 insertions, 14 deletions
diff --git a/addressbook/backend/pas/pas-backend-file.c b/addressbook/backend/pas/pas-backend-file.c index e117fe8b05..73f4f67fc9 100644 --- a/addressbook/backend/pas/pas-backend-file.c +++ b/addressbook/backend/pas/pas-backend-file.c @@ -54,7 +54,7 @@ get_nth(PASCardCursor *cursor, long n, gpointer data) PASBackendFileCursorPrivate *cursor_data = (PASBackendFileCursorPrivate *) data; GList *nth_item = g_list_nth(cursor_data->elements, n); - return (char*)nth_item->data; + return g_strdup((char*)nth_item->data); } static void @@ -220,13 +220,14 @@ pas_backend_file_build_all_cards_list(PASBackend *backend, PASBackendFile *bf = PAS_BACKEND_FILE (backend); DB *db = bf->priv->file_db; int db_error; - - cursor_data->elements = NULL; - do { - DBT id_dbt, vcard_dbt; - char *id; + DBT id_dbt, vcard_dbt; + char *id; - db_error = db->seq(db, &id_dbt, &vcard_dbt, R_NEXT); + cursor_data->elements = NULL; + + db_error = db->seq(db, &id_dbt, &vcard_dbt, R_NEXT); + + while (db_error == 0) { id = g_strndup(id_dbt.data, id_dbt.size); @@ -237,11 +238,13 @@ pas_backend_file_build_all_cards_list(PASBackend *backend, } else { g_free(id); - g_list_append(cursor_data->elements, g_strndup(vcard_dbt.data, - vcard_dbt.size)); + cursor_data->elements = g_list_append(cursor_data->elements, g_strndup(vcard_dbt.data, + vcard_dbt.size)); } - } while (db_error == 0); + db_error = db->seq(db, &id_dbt, &vcard_dbt, R_NEXT); + + } if (db_error == -1) { g_warning ("pas_backend_file_build_all_cards_list: error building list\n"); diff --git a/addressbook/backend/pas/pas-card-cursor.c b/addressbook/backend/pas/pas-card-cursor.c index b6ef91f41c..3f66848332 100644 --- a/addressbook/backend/pas/pas-card-cursor.c +++ b/addressbook/backend/pas/pas-card-cursor.c @@ -64,10 +64,13 @@ impl_pas_card_cursor_get_nth (PortableServer_Servant servant, CORBA_Environment *ev) { PASCardCursor *cursor = PAS_CARD_CURSOR (bonobo_object_from_servant (servant)); - if ( cursor->priv->get_nth ) - return cursor->priv->get_nth( cursor, n, cursor->priv->data ); - else - return ""; + if ( cursor->priv->get_nth ) { + char *vcard = cursor->priv->get_nth( cursor, n, cursor->priv->data ); + char *retval = CORBA_string_dup (vcard); + g_free (vcard); + return retval; + } else + return CORBA_string_dup (""); } /* |