diff options
| author | Matthew Barnes <mbarnes@redhat.com> | 2010-10-22 04:21:19 +0800 |
|---|---|---|
| committer | Matthew Barnes <mbarnes@redhat.com> | 2010-10-23 02:21:22 +0800 |
| commit | c881b5bc5e61d04b18d4ab46ad70533e7340d15b (patch) | |
| tree | e70a3ed0d2f93dacfe20d856de4d29578beb2e50 /addressbook | |
| parent | f0714755e2fa8b06425907c2cf189abd3a1b7119 (diff) | |
| download | gsoc2013-evolution-c881b5bc5e61d04b18d4ab46ad70533e7340d15b.tar.gz gsoc2013-evolution-c881b5bc5e61d04b18d4ab46ad70533e7340d15b.tar.zst gsoc2013-evolution-c881b5bc5e61d04b18d4ab46ad70533e7340d15b.zip | |
Simplify EActivity.
With unintrusive error dialogs gone, we can cut some unnecessary bits
out of EActivity.
I'm also adding a new enum property called "state", which is one of:
E_ACTIVITY_RUNNING
E_ACTIVITY_WAITING
E_ACTIVITY_CANCELLED
E_ACTIVITY_COMPLETED
The state of an activity must be explicitly changed. In particular,
when the user cancels an activity the state should be set only after
confirming the operation has been cancelled and not when cancellation
is requested (e.g. after receiving a G_IO_ERROR_CANCELLED, not when
the GCancellable emits "cancelled"). EActivityBar and EActivityProxy
widgets have been updated to make this distinction clearer in the UI.
E_ACTIVITY_WAITING will be used when activities have to be queued and
dispatched in sequence, which I haven't written yet.
Diffstat (limited to 'addressbook')
| -rw-r--r-- | addressbook/gui/widgets/e-addressbook-view.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/addressbook/gui/widgets/e-addressbook-view.c b/addressbook/gui/widgets/e-addressbook-view.c index fac9723923..fcf4dd3f7c 100644 --- a/addressbook/gui/widgets/e-addressbook-view.c +++ b/addressbook/gui/widgets/e-addressbook-view.c @@ -517,7 +517,7 @@ addressbook_view_dispose (GObject *object) if (priv->activity != NULL) { /* XXX Activity is not cancellable. */ - e_activity_complete (priv->activity); + e_activity_set_state (priv->activity, E_ACTIVITY_COMPLETED); g_object_unref (priv->activity); priv->activity = NULL; } @@ -1075,7 +1075,7 @@ status_message (EAddressbookView *view, if (status == NULL || *status == '\0') { if (activity != NULL) { - e_activity_complete (activity); + e_activity_set_state (activity, E_ACTIVITY_COMPLETED); g_object_unref (activity); view->priv->activity = NULL; } @@ -1083,11 +1083,11 @@ status_message (EAddressbookView *view, } else if (activity == NULL) { activity = e_activity_new (); view->priv->activity = activity; - e_activity_set_primary_text (activity, status); + e_activity_set_text (activity, status); e_shell_backend_add_activity (shell_backend, activity); } else - e_activity_set_primary_text (activity, status); + e_activity_set_text (activity, status); } static void |