aboutsummaryrefslogtreecommitdiffstats
path: root/calendar
diff options
context:
space:
mode:
authorJP Rosevear <jpr@ximian.com>2004-05-07 22:03:51 +0800
committerJP Rosevear <jpr@src.gnome.org>2004-05-07 22:03:51 +0800
commit1f5bf3a71fdf568c6b3c7b8f5bb548635cafd41a (patch)
tree3d25c56933de80772252c5777ee0ea9fb49bce23 /calendar
parent4e919deeff40049f3ca1dda409d21ea84f7700bd (diff)
downloadgsoc2013-evolution-1f5bf3a71fdf568c6b3c7b8f5bb548635cafd41a.tar.gz
gsoc2013-evolution-1f5bf3a71fdf568c6b3c7b8f5bb548635cafd41a.tar.zst
gsoc2013-evolution-1f5bf3a71fdf568c6b3c7b8f5bb548635cafd41a.zip
fix comment and check
2004-05-07 JP Rosevear <jpr@ximian.com> * gui/e-cal-model.c (ecm_is_cell_editable): fix comment and check * gui/e-cal-model-tasks.c (ecmt_set_value_at): set a parent field properly (ecmt_is_cell_editable): fix comment and check svn path=/trunk/; revision=25823
Diffstat (limited to 'calendar')
-rw-r--r--calendar/ChangeLog8
-rw-r--r--calendar/gui/e-cal-model-tasks.c9
-rw-r--r--calendar/gui/e-cal-model.c4
3 files changed, 15 insertions, 6 deletions
diff --git a/calendar/ChangeLog b/calendar/ChangeLog
index e07b78043b..29ddca2cea 100644
--- a/calendar/ChangeLog
+++ b/calendar/ChangeLog
@@ -1,3 +1,11 @@
+2004-05-07 JP Rosevear <jpr@ximian.com>
+
+ * gui/e-cal-model.c (ecm_is_cell_editable): fix comment and check
+
+ * gui/e-cal-model-tasks.c (ecmt_set_value_at): set a parent field
+ properly
+ (ecmt_is_cell_editable): fix comment and check
+
2004-05-06 Larry Ewing <lewing@ximian.com>
* gui/dialogs/calendar-setup.c (source_to_dialog): use random
diff --git a/calendar/gui/e-cal-model-tasks.c b/calendar/gui/e-cal-model-tasks.c
index 8128c40d76..5067e2557d 100644
--- a/calendar/gui/e-cal-model-tasks.c
+++ b/calendar/gui/e-cal-model-tasks.c
@@ -758,6 +758,11 @@ ecmt_set_value_at (ETableModel *etm, int col, int row, const void *value)
g_return_if_fail (col >= 0 && col < E_CAL_MODEL_TASKS_FIELD_LAST);
g_return_if_fail (row >= 0 && row < e_table_model_row_count (etm));
+ if (col < E_CAL_MODEL_FIELD_LAST) {
+ E_TABLE_MODEL_CLASS (parent_class)->set_value_at (etm, col, row, value);
+ return;
+ }
+
comp_data = e_cal_model_get_component_at (E_CAL_MODEL (model), row);
if (!comp_data)
return;
@@ -808,9 +813,7 @@ ecmt_is_cell_editable (ETableModel *etm, int col, int row)
priv = model->priv;
g_return_val_if_fail (col >= 0 && col < E_CAL_MODEL_TASKS_FIELD_LAST, FALSE);
-
- /* FIXME: We can't check this as 'click-to-add' passes row 0. */
- /* g_return_val_if_fail (row >= 0 && row < e_table_model_get_row_count (etm), FALSE); */
+ g_return_val_if_fail (row >= -1 && row < e_table_model_get_row_count (etm), FALSE);
if (col < E_CAL_MODEL_FIELD_LAST)
return E_TABLE_MODEL_CLASS (parent_class)->is_cell_editable (etm, col, row);
diff --git a/calendar/gui/e-cal-model.c b/calendar/gui/e-cal-model.c
index 25a866db3a..ca3ca1e863 100644
--- a/calendar/gui/e-cal-model.c
+++ b/calendar/gui/e-cal-model.c
@@ -671,9 +671,7 @@ ecm_is_cell_editable (ETableModel *etm, int col, int row)
priv = model->priv;
g_return_val_if_fail (col >= 0 && col <= E_CAL_MODEL_FIELD_LAST, FALSE);
-
- /* FIXME: We can't check this as 'click-to-add' passes row 0. */
- /*g_return_val_if_fail (row >= 0 && row < priv->objects->len, FALSE);*/
+ g_return_val_if_fail (row >= -1 && row < priv->objects->len, FALSE);
switch (col) {
case E_CAL_MODEL_FIELD_CATEGORIES :
91e099eea277f37ad45e5866d7'>Make "My Evolution" a normal storage instead of being the toplevelEttore Perazzoli2001-08-038-79/+285 * tree view iconsJakub Steiner2001-08-034-0/+5 * Call `gtk_drag_finish()' here.Ettore Perazzoli2001-08-032-3/+13 * Actually __fini the servant and deactivate the object too.Ettore Perazzoli2001-08-032-8/+20 * [Fixes #4663, startup crash.]Ettore Perazzoli2001-08-032-0/+16 * Also call `PortableServer_POA_deactivate_object()' on the progressEttore Perazzoli2001-08-032-1/+12 * Added. Provide description for filter_folder_op. (fetch_mail_describe):Jon Trowbridge2001-08-035-5/+52 * Spit out a warning if we cannot resolve "Bonobo/ConfigDatabase" onEttore Perazzoli2001-08-032-6/+18 * Add camel dependency.Jon Trowbridge2001-08-0316-142/+245 * Updated Swedish translation.Christian Rose2001-08-032-474/+603 * Wrap some debug printf's with d().Jeffrey Stedfast2001-08-034-93/+98 * handle null paths in the dialog so that we avoid printing NULL stringsLarry Ewing2001-08-032-1/+8 * Raise the filter-editor window if it's already created.Jeffrey Stedfast2001-08-032-1/+4 * Set the `set_folder_uri' to NULL when freeing it.Ettore Perazzoli2001-08-033-2/+11 * Install and use the new My Evolution icons from Jakub (they look reallyJacob Leach2001-08-035-15/+54 * I obviously can't spell recieved, er, received...uh, yea.Jeffrey Stedfast2001-08-032-2/+7 * Set history_id's for the sig and html sig gnome file entry boxes so it canJason Leach2001-08-032-1/+11 * Connect to the folder_remove signal on the storage. (vfolder_remove): NewJeffrey Stedfast2001-08-032-7/+8 * Make the right and left key presses be marked as handled here (i.e.,Christopher James Lahey2001-08-031-0/+2 * Connect to the folder_remove signal on the storage. (vfolder_remove): NewJeffrey Stedfast2001-08-035-66/+113 * my evolutionJakub Steiner2001-08-034-0/+7 * Changed all e_table_model_is_cell_editable calls in this file to be on theChristopher James Lahey2001-08-031-3/+3 * Set et->priv to NULL here just to be sure.Christopher James Lahey2001-08-031-0/+1 * Don't do most of the work in this function if data->data is NULL. FixesChristopher James Lahey2001-08-031-21/+27 * Added a <tip> for scrolling through mails.Kevin Breit2001-08-034-0/+24 * Removed some extra padding and pack the addressbook view into a frame withJason Leach2001-08-032-16/+24 * Update the updated Save, Save As, and Print icons for menus and theJason Leach2001-08-034-24/+39 * Revert mistaken commitJody Goldberg2001-08-021-3/+3 * Made "--without-guile" work. Added $guile_msg for reporting back.J.H.M. Dassen (Ray)2001-08-023-3/+23 * 10 POKE ICONS 20 PRINT "They look more consistent now!" 30 GOTO 10 RUNTuomas Kuosmanen2001-08-023-0/+0 * Added: addressbook/gui/contact-editor/e-contact-save-as.cChyla Zbigniew2001-08-022-0/+12 * avoid freed memory reading, when you call it likeRadek Doulik2001-08-021-2/+8 * receive dialog for the send/receive dialog -- /tigertTuomas Kuosmanen2001-08-023-0/+5 * Added ContactsSaveAsVCard, ContactsSendContactToOther, andChristopher James Lahey2001-08-022-6/+37 * ChangeLog fix. Should have been:Christopher James Lahey2001-08-021-1/+2 * Added ContactsSaveAsVCard, ContactsSendContactToOther, andChristopher James Lahey2001-08-024-29/+114 * Add EVOLUTION_BUTTONSDIR to get to some different icons.Not Zed2001-08-024-69/+116 * If the default category is the same as the value passed in to thisFederico Mena Quintero2001-08-024-3/+34 * Set the et->cursor_loc *before* committing the click-to-add to avoidFederico Mena Quintero2001-08-021-3/+7 * removed debugging messages.Damon Chaplin2001-08-022-9/+4 * removed some debugging messages.Damon Chaplin2001-08-022-38/+4 * Fixed the load statement here by just using array_from_string.Christopher James Lahey2001-08-022-47/+10 * Make this function not crash if x somehow doesn't land on some column.Christopher James Lahey2001-08-021-4/+8 * The calendar search bar widget now includes a drop-down menu of availableFederico Mena Quintero2001-08-0211-397/+561 * Do the Right Thing (tm) if the message list is not the widget in focusJeffrey Stedfast2001-08-022-0/+13 * Do a NULL-check on current_uri - socket is being closed? (as per theJeffrey Stedfast2001-08-022-4/+10 * This directory is *shared* between a lot of modules in GNOME CVS -Martin Baulig2001-08-011-0/+13 * fixed 2 mistranslated entriesSzabolcs Ban2001-08-011-2/+2 * fixed a mistranslated entrySzabolcs Ban2001-08-011-1/+1 * Updated Hungarian translation.Andras Timar2001-08-012-182/+170 * More updates to icons, this time the Save, Save As, and Search icons forJacob Leach2001-08-018-11/+32 * Don't move cursors around when deleting last message and Hide DeletedJason Leach2001-08-012-3/+12 * Made this not query the 0th row if there are 0 rows in the table. FixesChristopher James Lahey2001-08-011-6/+5 * Removed this file from this unused directory.Christopher James Lahey2001-08-012-8/+5 * Added file-exists.glade.Christopher James Lahey2001-08-014-1/+158 * Removed thrash checking code here since thrashing shouldn't happen nowChristopher James Lahey2001-08-013-83/+88 * If we fail to get the lock, make sure we close our locking fd, and resetNot Zed2001-08-012-1/+11 * Slightly re-arranged filter/change notification logic. If we;re filtering,Not Zed2001-08-014-42/+73 * The Wombat now keeps track of which categories are present in the objectsFederico Mena Quintero2001-08-019-155/+339 * Updated Spanish translation.Hector Garcia2001-08-012-531/+170 * Changed the title of this dialog to "Enter Password".Anna Marie Dirks2001-08-012-0/+7 * UpdateKjartan Maraas2001-08-011-17/+8 * Bump version number to 0.12.99.Ettore Perazzoli2001-08-012-2/+6 * Sync for the release.Ettore Perazzoli2001-08-01