diff options
| author | Jeffrey Stedfast <fejj@ximian.com> | 2001-08-10 12:23:32 +0800 |
|---|---|---|
| committer | Jeffrey Stedfast <fejj@src.gnome.org> | 2001-08-10 12:23:32 +0800 |
| commit | 5cfa31ba114380fa2a731ed1b2a55f6ef835dc5a (patch) | |
| tree | 545719eb4f5d13a9a824173e57b4a49c07454911 /mail/mail-ops.c | |
| parent | 8907111d47ab7c750a7e99636c21ceab51255243 (diff) | |
| download | gsoc2013-evolution-5cfa31ba114380fa2a731ed1b2a55f6ef835dc5a.tar.gz gsoc2013-evolution-5cfa31ba114380fa2a731ed1b2a55f6ef835dc5a.tar.zst gsoc2013-evolution-5cfa31ba114380fa2a731ed1b2a55f6ef835dc5a.zip | |
Added a comment about leaking memory here, but we seem to not even use the
2001-08-10 Jeffrey Stedfast <fejj@ximian.com>
* folder-browser.c (on_right_click): Added a comment about leaking
memory here, but we seem to not even use the 2 strings we
strdup...is this code still under construction?
* mail-ops.c (mail_send_message): Free the sent_folder_uri at the
bottom of the function (ironically enough we were freeing it if we
encountered an error but never free'd it on success :-)
(get_folderinfo_got): Fixed a memory leak...this one would have
gone away once we got rid of the debug g_warning though.
svn path=/trunk/; revision=11868
Diffstat (limited to 'mail/mail-ops.c')
| -rw-r--r-- | mail/mail-ops.c | 21 |
1 files changed, 13 insertions, 8 deletions
diff --git a/mail/mail-ops.c b/mail/mail-ops.c index c06069dddc..6a7564cba9 100644 --- a/mail/mail-ops.c +++ b/mail/mail-ops.c @@ -222,7 +222,7 @@ uid_cachename_hack (CamelStore *store) } static char * -fetch_mail_describe (struct _mail_msg *mm) +fetch_mail_describe (struct _mail_msg *mm, int complete) { return g_strdup (_("Fetching Mail")); } @@ -542,6 +542,7 @@ mail_send_message(CamelMimeMessage *message, const char *destination, CamelFilte if (sent_folder_uri) { folder = mail_tool_uri_to_folder (sent_folder_uri, NULL); + g_free (sent_folder_uri); if (!folder) { /* FIXME */ camel_object_ref (CAMEL_OBJECT (sent_folder)); @@ -1095,16 +1096,20 @@ static void get_folderinfo_got (struct _mail_msg *mm) { struct _get_folderinfo_msg *m = (struct _get_folderinfo_msg *)mm; - - if (camel_exception_is_set (&(mm->ex))) + + if (camel_exception_is_set (&mm->ex)) { + char *url; + + url = camel_service_get_url (CAMEL_SERVICE (m->store)); g_warning ("Error getting folder info from store at %s: %s", - camel_service_get_url (CAMEL_SERVICE (m->store)), - camel_exception_get_description (&(mm->ex))); - + url, camel_exception_get_description (&mm->ex)); + g_free (url); + } + /* 'done' is probably guaranteed to fail, but... */ - + if (m->done) - m->done(m->store, m->info, m->data); + m->done (m->store, m->info, m->data); } static void |