diff options
| author | Matthew Barnes <mbarnes@redhat.com> | 2009-12-17 02:39:39 +0800 |
|---|---|---|
| committer | Matthew Barnes <mbarnes@redhat.com> | 2009-12-17 02:39:39 +0800 |
| commit | f65f8935bce5538d490d872e9838874c83717953 (patch) | |
| tree | cfbe6490bcd4e8936319ce73088144fbb5aef707 /mail | |
| parent | 2a7f68fe45f3e60547212a6895a0fd202c5c3f09 (diff) | |
| download | gsoc2013-evolution-f65f8935bce5538d490d872e9838874c83717953.tar.gz gsoc2013-evolution-f65f8935bce5538d490d872e9838874c83717953.tar.zst gsoc2013-evolution-f65f8935bce5538d490d872e9838874c83717953.zip | |
Kill MailSession's interactive flag.
After analyzing this again I'm confident we really don't need it.
The only state change is from FALSE to TRUE at startup, and that
one-time event happens while the mail shell backend is starting up
(see: e_shell_backend_start()).
If a need arises to query for this in the future I'll extend the
EShellBackend API with an e_shell_backend_started() function, but
for now there's no need.
Diffstat (limited to 'mail')
| -rw-r--r-- | mail/mail-mt.c | 4 | ||||
| -rw-r--r-- | mail/mail-session.c | 33 | ||||
| -rw-r--r-- | mail/mail-session.h | 2 |
3 files changed, 0 insertions, 39 deletions
diff --git a/mail/mail-mt.c b/mail/mail-mt.c index b0c8ee8895..e2f6900e72 100644 --- a/mail/mail-mt.c +++ b/mail/mail-mt.c @@ -249,10 +249,6 @@ mail_msg_check_error (gpointer msg) checkmem(m->priv); #endif - /* don't report any errors if we are not in interactive mode */ - if (!mail_session_get_interactive ()) - return; - if (!camel_exception_is_set(&m->ex) || m->ex.id == CAMEL_EXCEPTION_USER_CANCEL || m->ex.id == CAMEL_EXCEPTION_FOLDER_INVALID_UID diff --git a/mail/mail-session.c b/mail/mail-session.c index e9ad274839..2360c064c0 100644 --- a/mail/mail-session.c +++ b/mail/mail-session.c @@ -755,39 +755,6 @@ mail_session_shutdown (void) camel_shutdown (); } -gboolean -mail_session_get_interactive (void) -{ - return MAIL_SESSION (session)->interactive; -} - -void -mail_session_set_interactive (gboolean interactive) -{ - MAIL_SESSION (session)->interactive = interactive; - - if (!interactive) { - struct _user_message_msg *msg; - - d(printf ("Gone non-interactive, checking for outstanding interactive tasks\n")); - - e_passwords_cancel(); - - /* flush/cancel pending user messages */ - while (!g_queue_is_empty (&user_message_queue)) { - msg = g_queue_pop_head (&user_message_queue); - e_flag_set (msg->done); - mail_msg_unref (msg); - } - - /* and the current */ - if (user_message_dialog) { - d(printf("Destroying message dialogue\n")); - gtk_widget_destroy ((GtkWidget *) user_message_dialog); - } - } -} - void mail_session_flush_filter_log (void) { diff --git a/mail/mail-session.h b/mail/mail-session.h index ccca89d199..9531852706 100644 --- a/mail/mail-session.h +++ b/mail/mail-session.h @@ -31,8 +31,6 @@ G_BEGIN_DECLS void mail_session_init (EShellBackend *shell_backend); void mail_session_shutdown (void); -gboolean mail_session_get_interactive (void); -void mail_session_set_interactive (gboolean interactive); gchar *mail_session_request_dialog (const gchar *prompt, gboolean secret, const gchar *key, gboolean async); gboolean mail_session_accept_dialog (const gchar *prompt, const gchar *key, |