Avoid using GdkEventButton directly in certain places.

Prefer dealing with GdkEvent pointers and using accessor functions like
gdk_event_get_button().

This is complicated by the fact that some GtkWidget method declarations
still use GdkEventButton pointers, and synthesizing button events pretty
much requires direct GdkEventButton access.  But GDK seems to be nudging
itself toward sealing the GdkEvent union.  Likely to happen in GDK4.

Mainly clean up signal handlers and leave method overrides alone for now.

1 files changed, 8 insertions, 3 deletions

diff --git a/smime/gui/certificate-manager.c b/smime/gui/certificate-manager.c
index acddc8a974..a48442f50b 100644
--- a/smime/gui/certificate-manager.c
+++ b/smime/gui/certificate-manager.c
@@ -325,16 +325,21 @@ report_and_free_error (CertPage *cp,
 
 static gboolean
 treeview_header_clicked (GtkWidget *widget,
-                         GdkEventButton *event,
+                         GdkEvent *button_event,
                          gpointer user_data)
 {
 	GtkMenu *menu = user_data;
+	guint event_button = 0;
+	guint32 event_time;
 
-	if (event->button != 3)
+	gdk_event_get_button (button_event, &event_button);
+	event_time = gdk_event_get_time (button_event);
+
+	if (event_button != 3)
 		return FALSE;
 
 	gtk_widget_show_all (GTK_WIDGET (menu));
-	gtk_menu_popup (menu, NULL, NULL, NULL, NULL, event->button, event->time);
+	gtk_menu_popup (menu, NULL, NULL, NULL, NULL, event_button, event_time);
 
 	return TRUE;
 }