diff options
Diffstat (limited to 'executive-summary')
-rw-r--r-- | executive-summary/ChangeLog | 55 | ||||
-rw-r--r-- | executive-summary/component/e-summary-url.c | 22 | ||||
-rw-r--r-- | executive-summary/component/e-summary.c | 28 | ||||
-rw-r--r-- | executive-summary/evolution-services/executive-summary-html-view.c | 31 |
4 files changed, 32 insertions, 104 deletions
diff --git a/executive-summary/ChangeLog b/executive-summary/ChangeLog index 8911e7154b..8a143acacf 100644 --- a/executive-summary/ChangeLog +++ b/executive-summary/ChangeLog @@ -1,58 +1,27 @@ -2001-03-08 Ettore Perazzoli <ettore@ximian.com> - - * component/component-factory.c (factory_fn): Specify a NULL - `EvolutionShellComponentGetDndSelectionFn'. - -2001-02-14 Iain Holmes <iain@ximian.com> - - * component/e-summary-url.c (e_summary_url_click): Remove the new - OTHER uri stuff. - -2001-02-14 Christopher James Lahey <clahey@ximian.com> - - * component/component-factory.c (component_destroy_cb): Removed - this unused function. +2001-02-27 Ettore Perazzoli <ettore@ximian.com> + + * Makefile.am (SUBDIRS): Remove `widgets'. - * evolution-services/executive-summary-html-view.c - (impl_GNOME_Evolution_Summary_HTMLView_handleURI): Changed the - declaration of this function to match the signature in the - generated header file. +2001-02-27 Ettore Perazzoli <ettore@ximian.com> - * test-service/rdf-summary.c (property_control): Added a cast here. + * Makefile.am (SUBDIRS): Add `widgets'. 2001-02-14 Iain Holmes <iain@ximian.com> - * evolution-services/executive-summary-html-view.c + * evolution-services/executive-summary-html-view.c (executive_summary_html_view_destroy): Don't unref the event source. - (impl_GNOME_Evolution_Summary_HTMLView_handleURI): Emit the signal. - (corba_class_init): Hook up the handleURI method. - (executive_summary_html_view_class_init): Create the signal. - - * idl/HTMLView.idl: Add the handleURI method. - -2001-02-13 Iain Holmes <iain@ximian.com> - * test-service/rdf-summary.c (property_control): Add an update now button. +2001-02-09 Iain Holmes <iain@ximian.com> -2001-02-12 Iain Holmes <iain@ximian.com> - - * test-service/rdf-summary.c (property_control): Add a "Update" spinner. - (property_action): Only download a new RDF if the URL changed. Use a cached - version otherwise. + * component/e-summary.c (e_summary_rebuild_page): Remove some debugging + prints. Stop some 0 length strings being passed to gtk_html_stream. 2001-02-08 Iain Holmes <iain@ximian.com> - * component/e-summary-url.c (e_summary_url_click): Close and remove the - window on an idle, so that the whole desktop isn't locked by a - GNOME-VFS bug. - -2001-02-13 Kjartan Maraas <kmaraas@gnome.org> + * component/e-summary-url.c (e_summary_url_click): Close and remove the + window on an idle, so that the whole desktop isn't locked by a + GNOME-VFS bug. - * Makefile.am: xml-i18n-tools setup for .oaf.in files. - * GNOME_Evolution_Summary.oaf.in: Mark strings for translation. - * test-service/Makefile.am: xml-i18n-tools setup for .oaf.in files. - * test-service/*.oaf.in: Mark strings for translation. - 2001-01-23 Iain Holmes <iain@ximian.com> * component/e-summary.c (e_summary_load_page): Don't strdup the NULL. diff --git a/executive-summary/component/e-summary-url.c b/executive-summary/component/e-summary-url.c index 4b26f1a85d..4a3ca724e3 100644 --- a/executive-summary/component/e-summary-url.c +++ b/executive-summary/component/e-summary-url.c @@ -25,16 +25,8 @@ #include <config.h> #endif -#include <bonobo/bonobo-property-control.h> -#include <bonobo/bonobo-event-source.h> -#include <bonobo/bonobo-widget.h> - -#include <libgnome/gnome-i18n.h> -#include <libgnome/gnome-url.h> -#include <libgnome/gnome-exec.h> -#include <libgnomeui/gnome-propertybox.h> - -#include <stdlib.h> +#include <gnome.h> +#include <bonobo.h> #include <gtkhtml/gtkhtml.h> #include <gtkhtml/gtkhtml-stream.h> @@ -503,10 +495,10 @@ e_summary_url_click (GtkWidget *widget, id->window = window; id->esummary = esummary; - /* Close the window on an idle to work around a bug in - gnome-vfs which locks the e_summary_remove_window function - and as gtkhtml has a pointer grab on, this locks the whole - display. GAH! */ + /* Close the window on an idle to work around a bug in gnome-vfs + which locaks the e_summary_remove_window function and as + gtkhtml has a pointer grab on, this locks the whole display. + GAH! */ g_idle_add (idle_remove_window, id); break; @@ -598,8 +590,8 @@ e_summary_url_click (GtkWidget *widget, e_summary_queue_rebuild (esummary); break; - case PROTOCOL_OTHER: case PROTOCOL_NONE: + case PROTOCOL_OTHER: case PROTOCOL_HTTP: case PROTOCOL_FILE: default: diff --git a/executive-summary/component/e-summary.c b/executive-summary/component/e-summary.c index 0e5d613ad8..dca93283a0 100644 --- a/executive-summary/component/e-summary.c +++ b/executive-summary/component/e-summary.c @@ -25,11 +25,8 @@ #include <config.h> #endif -#include <bonobo/bonobo-object.h> -#include <bonobo/bonobo-event-source.h> -#include <bonobo/bonobo-listener.h> -#include <bonobo/bonobo-property-bag.h> -#include <bonobo/bonobo-property-control.h> +#include <gnome.h> +#include <bonobo.h> #include <gtkhtml/gtkhtml.h> #include <gtkhtml/gtkhtml-embedded.h> @@ -517,7 +514,6 @@ e_summary_rebuild_page (ESummary *esummary) /* For each window on row i */ limit = MIN (columns, (numwindows - (i * columns))); for (k = 0; k < limit; k++) { - if (window == NULL) break; @@ -659,12 +655,7 @@ e_summary_add_service (ESummary *esummary, return NULL; } - unknown = Bonobo_Unknown_queryInterface (component, - "IDL:Bonobo/PropertyBag:1.0", - &ev); - window->propertybag = (Bonobo_PropertyBag) unknown; - - window->event_source = Bonobo_Unknown_queryInterface(window->propertybag, + window->event_source = Bonobo_Unknown_queryInterface(window->component, "IDL:Bonobo/EventSource:1.0", &ev); if (window->event_source == CORBA_OBJECT_NIL) { g_warning ("There is no Bonobo::EventSource interface"); @@ -681,6 +672,11 @@ e_summary_add_service (ESummary *esummary, window->listener_id = Bonobo_EventSource_addListener (window->event_source, listener, &ev); unknown = Bonobo_Unknown_queryInterface (component, + "IDL:Bonobo/PropertyBag:1.0", + &ev); + window->propertybag = (Bonobo_PropertyBag) unknown; + + unknown = Bonobo_Unknown_queryInterface (component, "IDL:Bonobo/PersistStream:1.0", &ev); window->persiststream = (Bonobo_PersistStream) unknown; @@ -694,10 +690,8 @@ e_summary_add_service (ESummary *esummary, window->title = bonobo_property_bag_client_get_value_string (window->propertybag, "window_title", NULL); - g_print ("title: %s\n", window->title); window->icon = bonobo_property_bag_client_get_value_string (window->propertybag, "window_icon", NULL); - g_print ("icon: %s\n", window->icon); CORBA_exception_free (&ev); priv->window_list = g_list_append (priv->window_list, window); @@ -751,7 +745,7 @@ e_summary_window_free (ESummaryWindow *window) if (ev._major != CORBA_NO_EXCEPTION) { g_warning ("CORBA ERROR: %s", CORBA_exception_id (&ev)); } - bonobo_object_release_unref (window->event_source, &ev); + bonobo_object_release_unref (window->event_source, &ev); } bonobo_object_release_unref (window->propertybag, &ev); @@ -759,9 +753,10 @@ e_summary_window_free (ESummaryWindow *window) bonobo_object_release_unref (window->propertycontrol, &ev); bonobo_object_unref (BONOBO_OBJECT (window->listener)); bonobo_object_release_unref (window->html, &ev); - + bonobo_object_release_unref (window->component, &ev); CORBA_exception_free (&ev); + g_free (window); } @@ -1213,6 +1208,7 @@ e_summary_save_state (ESummary *esummary, fullpath = g_strdup_printf("%s/Executive-Summary", path); g_print ("fullpath: %s\n", fullpath); + /* FIXME: Use RC's rmdir function */ e_summary_rm_dir (fullpath); storage = bonobo_storage_open (STORAGE_TYPE, fullpath, diff --git a/executive-summary/evolution-services/executive-summary-html-view.c b/executive-summary/evolution-services/executive-summary-html-view.c index 45f2e86c16..07da71c9e7 100644 --- a/executive-summary/evolution-services/executive-summary-html-view.c +++ b/executive-summary/evolution-services/executive-summary-html-view.c @@ -42,13 +42,6 @@ static void executive_summary_html_view_class_init (ExecutiveSummaryHtmlViewClas static BonoboObjectClass *parent_class; -enum { - HANDLE_URI, - LAST_SIGNAL -}; - -static guint signals[LAST_SIGNAL] = { 0 }; - struct _ExecutiveSummaryHtmlViewPrivate { BonoboEventSource *event_source; @@ -95,18 +88,6 @@ impl_GNOME_Evolution_Summary_HTMLView_getHtml (PortableServer_Servant servant, return CORBA_string_dup (priv->html? priv->html: ""); } -static void -impl_GNOME_Evolution_Summary_HTMLView_handleURI (PortableServer_Servant servant, - const CORBA_char *uri, - CORBA_Environment *ev) -{ - BonoboObject *bonobo_object; - - bonobo_object = bonobo_object_from_servant (servant); - - gtk_signal_emit (GTK_OBJECT (bonobo_object), signals[HANDLE_URI], uri); -} - /* GtkObject methods */ static void executive_summary_html_view_destroy (GtkObject *object) @@ -114,13 +95,13 @@ executive_summary_html_view_destroy (GtkObject *object) ExecutiveSummaryHtmlView *view; ExecutiveSummaryHtmlViewPrivate *priv; - g_print ("BANG!"); view = EXECUTIVE_SUMMARY_HTML_VIEW (object); priv = view->private; if (priv == NULL) return; +/* bonobo_object_unref (BONOBO_OBJECT (priv->event_source)); */ g_free (priv->html); g_free (priv); @@ -143,7 +124,6 @@ corba_class_init (void) epv = g_new0 (POA_GNOME_Evolution_Summary_HTMLView__epv, 1); epv->getHtml = impl_GNOME_Evolution_Summary_HTMLView_getHtml; - epv->handleURI = impl_GNOME_Evolution_Summary_HTMLView_handleURI; vepv = &HTMLView_vepv; vepv->_base_epv = base_epv; @@ -159,15 +139,6 @@ executive_summary_html_view_class_init (ExecutiveSummaryHtmlViewClass *klass) object_class = GTK_OBJECT_CLASS (klass); object_class->destroy = executive_summary_html_view_destroy; - signals[HANDLE_URI] = gtk_signal_new ("handle_uri", GTK_RUN_FIRST, - object_class->type, - GTK_SIGNAL_OFFSET (ExecutiveSummaryHtmlViewClass, handle_uri), - gtk_marshal_NONE__POINTER, - GTK_TYPE_NONE, 1, - GTK_TYPE_POINTER); - - gtk_object_class_add_signals (object_class, signals, LAST_SIGNAL); - parent_class = gtk_type_class (PARENT_TYPE); corba_class_init (); |