diff options
author | Dan J Miller <danjm.com@gmail.com> | 2019-03-06 02:14:02 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-03-06 02:14:02 +0800 |
commit | f334f4da154378d2a8f5739e806bae787bf77aba (patch) | |
tree | ccca11fafe792c9b7c02137364c6565d6bef59c1 /ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js | |
parent | e31efa250c28d152beb354f3355b60a7421db86c (diff) | |
download | tangerine-wallet-browser-f334f4da154378d2a8f5739e806bae787bf77aba.tar.gz tangerine-wallet-browser-f334f4da154378d2a8f5739e806bae787bf77aba.tar.zst tangerine-wallet-browser-f334f4da154378d2a8f5739e806bae787bf77aba.zip |
Metametrics fixes (#6238)
* Improve opt-in opt-out event tracking after going 'back' in onboarding.
* Fix 'Switched Networks' metrics event.
* Fix custom variables ids (can only use ids 1-5)
* Fix tracking of function type custom variable for metametrics in confirm-transaction-base
* Add missing metametrics events
Diffstat (limited to 'ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js')
-rw-r--r-- | ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js b/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js index e76b4699b..8b101b1ba 100644 --- a/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js +++ b/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js @@ -157,7 +157,7 @@ export default class ConfirmTransactionBase extends Component { } handleEditGas () { - const { onEditGas, showCustomizeGasModal, methodData = {}, txData: { origin } } = this.props + const { onEditGas, showCustomizeGasModal, action, txData: { origin }, methodData = {} } = this.props this.context.metricsEvent({ eventOpts: { @@ -167,7 +167,7 @@ export default class ConfirmTransactionBase extends Component { }, customVariables: { recipientKnown: null, - functionType: methodData.name || 'notFound', + functionType: action || getMethodName(methodData.name) || this.context.t('contractInteraction'), origin, }, }) @@ -290,7 +290,7 @@ export default class ConfirmTransactionBase extends Component { } handleEdit () { - const { txData, tokenData, tokenProps, onEdit, methodData = {}, txData: { origin } } = this.props + const { txData, tokenData, tokenProps, onEdit, action, txData: { origin }, methodData = {} } = this.props this.context.metricsEvent({ eventOpts: { @@ -300,7 +300,7 @@ export default class ConfirmTransactionBase extends Component { }, customVariables: { recipientKnown: null, - functionType: methodData.name || 'notFound', + functionType: action || getMethodName(methodData.name) || this.context.t('contractInteraction'), origin, }, }) @@ -329,7 +329,7 @@ export default class ConfirmTransactionBase extends Component { handleCancel () { const { metricsEvent } = this.context - const { onCancel, txData, cancelTransaction, history, clearConfirmTransaction, methodData = {}, txData: { origin } } = this.props + const { onCancel, txData, cancelTransaction, history, clearConfirmTransaction, action, txData: { origin }, methodData = {} } = this.props if (onCancel) { metricsEvent({ @@ -340,7 +340,7 @@ export default class ConfirmTransactionBase extends Component { }, customVariables: { recipientKnown: null, - functionType: methodData.name || 'notFound', + functionType: action || getMethodName(methodData.name) || this.context.t('contractInteraction'), origin, }, }) @@ -356,7 +356,7 @@ export default class ConfirmTransactionBase extends Component { handleSubmit () { const { metricsEvent } = this.context - const { txData: { origin }, sendTransaction, clearConfirmTransaction, txData, history, onSubmit, methodData = {}, metaMetricsSendCount = 0, setMetaMetricsSendCount } = this.props + const { txData: { origin }, sendTransaction, clearConfirmTransaction, txData, history, onSubmit, action, metaMetricsSendCount = 0, setMetaMetricsSendCount, methodData = {} } = this.props const { submitting } = this.state if (submitting) { @@ -375,7 +375,7 @@ export default class ConfirmTransactionBase extends Component { }, customVariables: { recipientKnown: null, - functionType: methodData.name || 'notFound', + functionType: action || getMethodName(methodData.name) || this.context.t('contractInteraction'), origin, }, }) |