Prevent users from changing the From field in the send screen (#5922)

* Prevent users from changing the From field in the send screen

* Fix integration tests

2 files changed, 12 insertions, 186 deletions

diff --git a/ui/app/components/send/send-content/send-from-row/tests/send-from-row-component.test.js b/ui/app/components/send/send-content/send-from-row/tests/send-from-row-component.test.js
index 9ba8d1739..18811c57e 100644
--- a/ui/app/components/send/send-content/send-from-row/tests/send-from-row-component.test.js
+++ b/ui/app/components/send/send-content/send-from-row/tests/send-from-row-component.test.js
@@ -1,121 +1,31 @@
 import React from 'react'
 import assert from 'assert'
 import { shallow } from 'enzyme'
-import sinon from 'sinon'
 import SendFromRow from '../send-from-row.component.js'
-
+import AccountListItem from '../../../account-list-item'
 import SendRowWrapper from '../../send-row-wrapper/send-row-wrapper.component'
-import FromDropdown from '../from-dropdown/from-dropdown.component'
-
-const propsMethodSpies = {
-  closeFromDropdown: sinon.spy(),
-  openFromDropdown: sinon.spy(),
-  updateSendFrom: sinon.spy(),
-  setSendTokenBalance: sinon.spy(),
-}
-
-sinon.spy(SendFromRow.prototype, 'handleFromChange')
 
 describe('SendFromRow Component', function () {
-  let wrapper
-  let instance
-
-  beforeEach(() => {
-    wrapper = shallow(<SendFromRow
-      closeFromDropdown={propsMethodSpies.closeFromDropdown}
-      conversionRate={15}
-      from={ { address: 'mockAddress' } }
-      fromAccounts={['mockAccount']}
-      fromDropdownOpen={false}
-      openFromDropdown={propsMethodSpies.openFromDropdown}
-      setSendTokenBalance={propsMethodSpies.setSendTokenBalance}
-      tokenContract={null}
-      updateSendFrom={propsMethodSpies.updateSendFrom}
-    />, { context: { t: str => str + '_t' } })
-    instance = wrapper.instance()
-  })
-
-  afterEach(() => {
-    propsMethodSpies.closeFromDropdown.resetHistory()
-    propsMethodSpies.openFromDropdown.resetHistory()
-    propsMethodSpies.updateSendFrom.resetHistory()
-    propsMethodSpies.setSendTokenBalance.resetHistory()
-    SendFromRow.prototype.handleFromChange.resetHistory()
-  })
-
-  describe('handleFromChange', () => {
-
-    it('should call updateSendFrom', () => {
-      assert.equal(propsMethodSpies.updateSendFrom.callCount, 0)
-      instance.handleFromChange('mockFrom')
-      assert.equal(propsMethodSpies.updateSendFrom.callCount, 1)
-      assert.deepEqual(
-        propsMethodSpies.updateSendFrom.getCall(0).args,
-        ['mockFrom']
-      )
-    })
-
-    it('should call tokenContract.balanceOf and setSendTokenBalance if tokenContract is defined', async () => {
-      wrapper.setProps({
-        tokenContract: {
-          balanceOf: () => new Promise((resolve) => resolve('mockUsersToken')),
-        },
-      })
-      assert.equal(propsMethodSpies.setSendTokenBalance.callCount, 0)
-      await instance.handleFromChange('mockFrom')
-      assert.equal(propsMethodSpies.setSendTokenBalance.callCount, 1)
-      assert.deepEqual(
-        propsMethodSpies.setSendTokenBalance.getCall(0).args,
-        ['mockUsersToken']
-      )
-    })
-
-  })
-
   describe('render', () => {
+    const wrapper = shallow(
+      <SendFromRow
+        from={ { address: 'mockAddress' } }
+      />,
+      { context: { t: str => str + '_t' } }
+    )
+
     it('should render a SendRowWrapper component', () => {
       assert.equal(wrapper.find(SendRowWrapper).length, 1)
     })
 
     it('should pass the correct props to SendRowWrapper', () => {
-      const {
-        label,
-      } = wrapper.find(SendRowWrapper).props()
-
+      const { label } = wrapper.find(SendRowWrapper).props()
       assert.equal(label, 'from_t:')
     })
 
-    it('should render an FromDropdown as a child of the SendRowWrapper', () => {
-      assert(wrapper.find(SendRowWrapper).childAt(0).is(FromDropdown))
-    })
-
     it('should render the FromDropdown with the correct props', () => {
-      const {
-        accounts,
-        closeDropdown,
-        conversionRate,
-        dropdownOpen,
-        onSelect,
-        openDropdown,
-        selectedAccount,
-      } = wrapper.find(SendRowWrapper).childAt(0).props()
-      assert.deepEqual(accounts, ['mockAccount'])
-      assert.equal(dropdownOpen, false)
-      assert.equal(conversionRate, 15)
-      assert.deepEqual(selectedAccount, { address: 'mockAddress' })
-      assert.equal(propsMethodSpies.closeFromDropdown.callCount, 0)
-      closeDropdown()
-      assert.equal(propsMethodSpies.closeFromDropdown.callCount, 1)
-      assert.equal(propsMethodSpies.openFromDropdown.callCount, 0)
-      openDropdown()
-      assert.equal(propsMethodSpies.openFromDropdown.callCount, 1)
-      assert.equal(SendFromRow.prototype.handleFromChange.callCount, 0)
-      onSelect('mockNewFrom')
-      assert.equal(SendFromRow.prototype.handleFromChange.callCount, 1)
-      assert.deepEqual(
-        SendFromRow.prototype.handleFromChange.getCall(0).args,
-        ['mockNewFrom']
-      )
+      const { account } = wrapper.find(AccountListItem).props()
+      assert.deepEqual(account, { address: 'mockAddress' })
     })
   })
 })
diff --git a/ui/app/components/send/send-content/send-from-row/tests/send-from-row-container.test.js b/ui/app/components/send/send-content/send-from-row/tests/send-from-row-container.test.js
index e080b2fe3..fd771ea77 100644
--- a/ui/app/components/send/send-content/send-from-row/tests/send-from-row-container.test.js
+++ b/ui/app/components/send/send-content/send-from-row/tests/send-from-row-container.test.js
@@ -1,110 +1,26 @@
 import assert from 'assert'
 import proxyquire from 'proxyquire'
-import sinon from 'sinon'
 
 let mapStateToProps
-let mapDispatchToProps
-
-const actionSpies = {
-  updateSendFrom: sinon.spy(),
-  setSendTokenBalance: sinon.spy(),
-}
-const duckActionSpies = {
-  closeFromDropdown: sinon.spy(),
-  openFromDropdown: sinon.spy(),
-}
 
 proxyquire('../send-from-row.container.js', {
   'react-redux': {
-    connect: (ms, md) => {
+    connect: ms => {
       mapStateToProps = ms
-      mapDispatchToProps = md
       return () => ({})
     },
   },
   '../../send.selectors.js': {
-    accountsWithSendEtherInfoSelector: (s) => `mockFromAccounts:${s}`,
-    getConversionRate: (s) => `mockConversionRate:${s}`,
-    getSelectedTokenContract: (s) => `mockTokenContract:${s}`,
     getSendFromObject: (s) => `mockFrom:${s}`,
   },
-  './send-from-row.selectors.js': { getFromDropdownOpen: (s) => `mockFromDropdownOpen:${s}` },
-  '../../send.utils.js': { calcTokenBalance: ({ usersToken, selectedToken }) => usersToken + selectedToken },
-  '../../../../actions': actionSpies,
-  '../../../../ducks/send.duck': duckActionSpies,
 })
 
 describe('send-from-row container', () => {
-
   describe('mapStateToProps()', () => {
-
     it('should map the correct properties to props', () => {
       assert.deepEqual(mapStateToProps('mockState'), {
-        conversionRate: 'mockConversionRate:mockState',
         from: 'mockFrom:mockState',
-        fromAccounts: 'mockFromAccounts:mockState',
-        fromDropdownOpen: 'mockFromDropdownOpen:mockState',
-        tokenContract: 'mockTokenContract:mockState',
-      })
-    })
-
-  })
-
-  describe('mapDispatchToProps()', () => {
-    let dispatchSpy
-    let mapDispatchToPropsObject
-
-    beforeEach(() => {
-      dispatchSpy = sinon.spy()
-      mapDispatchToPropsObject = mapDispatchToProps(dispatchSpy)
-    })
-
-    describe('closeFromDropdown()', () => {
-      it('should dispatch a closeFromDropdown action', () => {
-        mapDispatchToPropsObject.closeFromDropdown()
-        assert(dispatchSpy.calledOnce)
-        assert(duckActionSpies.closeFromDropdown.calledOnce)
-        assert.equal(
-          duckActionSpies.closeFromDropdown.getCall(0).args[0],
-          undefined
-        )
       })
     })
-
-    describe('openFromDropdown()', () => {
-      it('should dispatch a openFromDropdown action', () => {
-        mapDispatchToPropsObject.openFromDropdown()
-        assert(dispatchSpy.calledOnce)
-        assert(duckActionSpies.openFromDropdown.calledOnce)
-        assert.equal(
-          duckActionSpies.openFromDropdown.getCall(0).args[0],
-          undefined
-        )
-      })
-    })
-
-    describe('updateSendFrom()', () => {
-      it('should dispatch an updateSendFrom action', () => {
-        mapDispatchToPropsObject.updateSendFrom('mockFrom')
-        assert(dispatchSpy.calledOnce)
-        assert.equal(
-          actionSpies.updateSendFrom.getCall(0).args[0],
-          'mockFrom'
-        )
-      })
-    })
-
-    describe('setSendTokenBalance()', () => {
-      it('should dispatch an setSendTokenBalance action', () => {
-        mapDispatchToPropsObject.setSendTokenBalance('mockUsersToken', 'mockSelectedToken')
-        assert(dispatchSpy.calledOnce)
-        assert.equal(
-          actionSpies.setSendTokenBalance.getCall(0).args[0],
-          'mockUsersTokenmockSelectedToken'
-        )
-      })
-    })
-
   })
-
 })