Use Parity on-chain registry only when is needed (#6052)

* add and use knownMethodData to avoid infura requests

* dataMethod to methodData and check empty response

1 files changed, 16 insertions, 3 deletions

diff --git a/ui/app/higher-order-components/with-method-data/with-method-data.component.js b/ui/app/higher-order-components/with-method-data/with-method-data.component.js
index fed7d9865..08b9083e1 100644
--- a/ui/app/higher-order-components/with-method-data/with-method-data.component.js
+++ b/ui/app/higher-order-components/with-method-data/with-method-data.component.js
@@ -1,15 +1,18 @@
 import React, { PureComponent } from 'react'
 import PropTypes from 'prop-types'
-import { getMethodData } from '../../helpers/transactions.util'
+import { getMethodData, getFourBytePrefix } from '../../helpers/transactions.util'
 
 export default function withMethodData (WrappedComponent) {
   return class MethodDataWrappedComponent extends PureComponent {
     static propTypes = {
       transaction: PropTypes.object,
+      knownMethodData: PropTypes.object,
+      addKnownMethodData: PropTypes.func,
     }
 
     static defaultProps = {
       transaction: {},
+      knownMethodData: {},
     }
 
     state = {
@@ -23,12 +26,22 @@ export default function withMethodData (WrappedComponent) {
     }
 
     async fetchMethodData () {
-      const { transaction } = this.props
+      const { transaction, knownMethodData, addKnownMethodData } = this.props
       const { txParams: { data = '' } = {} } = transaction
 
       if (data) {
         try {
-          const methodData = await getMethodData(data)
+          let methodData
+          const fourBytePrefix = getFourBytePrefix(data)
+          if (fourBytePrefix in knownMethodData) {
+            methodData = knownMethodData[fourBytePrefix]
+          } else {
+            methodData = await getMethodData(data)
+            if (!Object.entries(methodData).length === 0) {
+              addKnownMethodData(fourBytePrefix, methodData)
+            }
+          }
+
           this.setState({ methodData, done: true })
         } catch (error) {
           this.setState({ done: true, error })